Browse Source

rev-parse test: use test_must_fail, not "if <command>; then false; fi"

This way, if rev-parse segfaults then the test will fail instead
of treating it the same way as a controlled failure.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Felipe Contreras 12 years ago committed by Junio C Hamano
parent
commit
d8f7681337
  1. 4
      t/t6101-rev-parse-parents.sh

4
t/t6101-rev-parse-parents.sh

@ -26,7 +26,7 @@ test_expect_success 'start^0' '
' '


test_expect_success 'start^1 not valid' ' test_expect_success 'start^1 not valid' '
if git rev-parse --verify start^1; then false; else :; fi test_must_fail git rev-parse --verify start^1
' '


test_expect_success 'second^1 = second^' ' test_expect_success 'second^1 = second^' '
@ -50,7 +50,7 @@ test_expect_success 'final^1^2 != final^1^1' '
' '


test_expect_success 'final^1^3 not valid' ' test_expect_success 'final^1^3 not valid' '
if git rev-parse --verify final^1^3; then false; else :; fi test_must_fail git rev-parse --verify final^1^3
' '


test_expect_success '--verify start2^1' ' test_expect_success '--verify start2^1' '

Loading…
Cancel
Save