Browse Source

graph API: fix a bug in the rendering of octopus merges

An off by one error was causing octopus merges with 3 parents to not be
rendered correctly.  This regression was introduced by 427fc5.

Signed-off-by: Allan Caffee <allan.caffee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Allan Caffee 16 years ago committed by Junio C Hamano
parent
commit
a6c1a3827c
  1. 2
      graph.c
  2. 2
      t/t4202-log.sh

2
graph.c

@ -852,7 +852,7 @@ static void graph_output_commit_line(struct git_graph *graph, struct strbuf *sb) @@ -852,7 +852,7 @@ static void graph_output_commit_line(struct git_graph *graph, struct strbuf *sb)
graph_output_commit_char(graph, sb);
chars_written++;

if (graph->num_parents > 3)
if (graph->num_parents > 2)
chars_written += graph_draw_octopus_merge(graph,
sb);
} else if (seen_this && (graph->num_parents > 2)) {

2
t/t4202-log.sh

@ -342,7 +342,7 @@ cat > expect <<\EOF @@ -342,7 +342,7 @@ cat > expect <<\EOF
* initial
EOF

test_expect_failure 'log --graph with merge' '
test_expect_sucess 'log --graph with merge' '
git log --graph --date-order --pretty=tformat:%s |
sed "s/ *$//" >actual &&
test_cmp expect actual

Loading…
Cancel
Save