kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Merge branch 'jc/remote-insteadof-leakfix' into seen 

ewrites_release() in remote.c has been updated to free struct
rewrite instances and their instead_of arrays, and handle_config()
now borrows string values directly from repo_config().

* jc/remote-insteadof-leakfix:
  remote: plug memory leaks
seen
Junio C Hamano 2026-07-24 17:46:05 -07:00
parent bb582869ff 19a305bd22
commit 93d9c8b90b
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
remote.c
View File

@ -309,8 +309,11 @@ static struct rewrite *make_rewrite(struct rewrites *r,

static void rewrites_release(struct rewrites *r)
{
for (int i = 0; i < r->rewrite_nr; i++)
for (int i = 0; i < r->rewrite_nr; i++) {
free((char *)r->rewrite[i]->base);
free(r->rewrite[i]->instead_of);
free(r->rewrite[i]);
}
free(r->rewrite);
memset(r, 0, sizeof(*r));
}
@ -469,13 +472,13 @@ static int handle_config(const char *key, const char *value,
return config_error_nonbool(key);
rewrite = make_rewrite(&remote_state->rewrites, name,
namelen);
add_instead_of(rewrite, xstrdup(value));
add_instead_of(rewrite, value);
} else if (!strcmp(subkey, "pushinsteadof")) {
if (!value)
return config_error_nonbool(key);
rewrite = make_rewrite(&remote_state->rewrites_push,
name, namelen);
add_instead_of(rewrite, xstrdup(value));
add_instead_of(rewrite, value);
}
}