kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

remote: plug memory leaks 

The in-core data structure used to keep track of
'url.<real>.{insteadOf,pushInsteadOf} = <alias>' settings is not
properly cleaned up when the process is done with it.

Fix the rewrites_release() function to free not just the 'struct
rewrites' instance itself, but also allocated structures that are
pointed at by the 'struct rewrites' instance.  One of the embedded
structures holds a 'const char *' to point at a borrowed constant
string from a configuration callback.  Since the code does not
modify this string, stop copying the value (alias URL) before
registering it in 'struct rewrite', as nobody is freeing this
member, to avoid leaking the extra copy.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
seen
Junio C Hamano 2026-07-24 17:43:26 -07:00
parent 94f057755b
commit 19a305bd22
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
remote.c
View File

@ -304,8 +304,11 @@ static struct rewrite *make_rewrite(struct rewrites *r,

static void rewrites_release(struct rewrites *r)
{
for (int i = 0; i < r->rewrite_nr; i++)
for (int i = 0; i < r->rewrite_nr; i++) {
free((char *)r->rewrite[i]->base);
free(r->rewrite[i]->instead_of);
free(r->rewrite[i]);
}
free(r->rewrite);
memset(r, 0, sizeof(*r));
}
@ -464,13 +467,13 @@ static int handle_config(const char *key, const char *value,
return config_error_nonbool(key);
rewrite = make_rewrite(&remote_state->rewrites, name,
namelen);
add_instead_of(rewrite, xstrdup(value));
add_instead_of(rewrite, value);
} else if (!strcmp(subkey, "pushinsteadof")) {
if (!value)
return config_error_nonbool(key);
rewrite = make_rewrite(&remote_state->rewrites_push,
name, namelen);
add_instead_of(rewrite, xstrdup(value));
add_instead_of(rewrite, value);
}
}