Browse Source

hashcmp(): inline memcmp() by hand to optimize

This is reported to speed "git gc" by 18%.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Ingo Molnar 14 years ago committed by Junio C Hamano
parent
commit
1a812f3a70
  1. 18
      cache.h

18
cache.h

@ -614,14 +614,24 @@ extern char *sha1_pack_name(const unsigned char *sha1); @@ -614,14 +614,24 @@ extern char *sha1_pack_name(const unsigned char *sha1);
extern char *sha1_pack_index_name(const unsigned char *sha1);
extern const char *find_unique_abbrev(const unsigned char *sha1, int);
extern const unsigned char null_sha1[20];
static inline int is_null_sha1(const unsigned char *sha1)

static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2)
{
return !memcmp(sha1, null_sha1, 20);
int i;

for (i = 0; i < 20; i++, sha1++, sha2++) {
if (*sha1 != *sha2)
return *sha1 - *sha2;
}

return 0;
}
static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2)

static inline int is_null_sha1(const unsigned char *sha1)
{
return memcmp(sha1, sha2, 20);
return !hashcmp(sha1, null_sha1);
}

static inline void hashcpy(unsigned char *sha_dst, const unsigned char *sha_src)
{
memcpy(sha_dst, sha_src, 20);

Loading…
Cancel
Save