|
|
|
/*
|
|
|
|
* git-imap-send - drops patches into an imap Drafts folder
|
|
|
|
* derived from isync/mbsync - mailbox synchronizer
|
|
|
|
*
|
|
|
|
* Copyright (C) 2000-2002 Michael R. Elkins <me@mutt.org>
|
|
|
|
* Copyright (C) 2002-2004 Oswald Buddenhagen <ossi@users.sf.net>
|
|
|
|
* Copyright (C) 2004 Theodore Y. Ts'o <tytso@mit.edu>
|
|
|
|
* Copyright (C) 2006 Mike McCormack
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "cache.h"
|
|
|
|
#include "exec_cmd.h"
|
|
|
|
#include "run-command.h"
|
|
|
|
#ifdef NO_OPENSSL
|
|
|
|
typedef void *SSL;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
struct store_conf {
|
|
|
|
char *name;
|
|
|
|
const char *path; /* should this be here? its interpretation is driver-specific */
|
|
|
|
char *map_inbox;
|
|
|
|
char *trash;
|
|
|
|
unsigned max_size; /* off_t is overkill */
|
|
|
|
unsigned trash_remote_new:1, trash_only_new:1;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct string_list {
|
|
|
|
struct string_list *next;
|
|
|
|
char string[1];
|
|
|
|
};
|
|
|
|
|
|
|
|
struct channel_conf {
|
|
|
|
struct channel_conf *next;
|
|
|
|
char *name;
|
|
|
|
struct store_conf *master, *slave;
|
|
|
|
char *master_name, *slave_name;
|
|
|
|
char *sync_state;
|
|
|
|
struct string_list *patterns;
|
|
|
|
int mops, sops;
|
|
|
|
unsigned max_messages; /* for slave only */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct group_conf {
|
|
|
|
struct group_conf *next;
|
|
|
|
char *name;
|
|
|
|
struct string_list *channels;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* For message->status */
|
|
|
|
#define M_RECENT (1<<0) /* unsyncable flag; maildir_* depend on this being 1<<0 */
|
|
|
|
#define M_DEAD (1<<1) /* expunged */
|
|
|
|
#define M_FLAGS (1<<2) /* flags fetched */
|
|
|
|
|
|
|
|
struct message {
|
|
|
|
struct message *next;
|
|
|
|
/* struct string_list *keywords; */
|
|
|
|
size_t size; /* zero implies "not fetched" */
|
|
|
|
int uid;
|
|
|
|
unsigned char flags, status;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct store {
|
|
|
|
struct store_conf *conf; /* foreign */
|
|
|
|
|
|
|
|
/* currently open mailbox */
|
|
|
|
const char *name; /* foreign! maybe preset? */
|
|
|
|
char *path; /* own */
|
|
|
|
struct message *msgs; /* own */
|
|
|
|
int uidvalidity;
|
|
|
|
unsigned char opts; /* maybe preset? */
|
|
|
|
/* note that the following do _not_ reflect stats from msgs, but mailbox totals */
|
|
|
|
int count; /* # of messages */
|
|
|
|
int recent; /* # of recent messages - don't trust this beyond the initial read */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct msg_data {
|
|
|
|
char *data;
|
|
|
|
int len;
|
|
|
|
unsigned char flags;
|
|
|
|
unsigned int crlf:1;
|
|
|
|
};
|
|
|
|
|
|
|
|
static const char imap_send_usage[] = "git imap-send < <mbox>";
|
|
|
|
|
|
|
|
#undef DRV_OK
|
|
|
|
#define DRV_OK 0
|
|
|
|
#define DRV_MSG_BAD -1
|
|
|
|
#define DRV_BOX_BAD -2
|
|
|
|
#define DRV_STORE_BAD -3
|
|
|
|
|
|
|
|
static int Verbose, Quiet;
|
|
|
|
|
|
|
|
__attribute__((format (printf, 1, 2)))
|
|
|
|
static void imap_info(const char *, ...);
|
|
|
|
__attribute__((format (printf, 1, 2)))
|
|
|
|
static void imap_warn(const char *, ...);
|
|
|
|
|
|
|
|
static char *next_arg(char **);
|
|
|
|
|
|
|
|
static void free_generic_messages(struct message *);
|
|
|
|
|
|
|
|
__attribute__((format (printf, 3, 4)))
|
|
|
|
static int nfsnprintf(char *buf, int blen, const char *fmt, ...);
|
|
|
|
|
nfv?asprintf are broken without va_copy, workaround them.
* drop nfasprintf.
* move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
and die() in case of overflow. It should be enough for imap commands, if
someone cares about imap-send, he's welcomed to fix it properly.
* replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
logic, it's one place, we'll live with it.
To ease the change, output_buffer string list is replaced with a strbuf ;)
* rework trace.c to call vsnprintf itself. It's used to format strerror()s
and git command names, it should never be more than a few octets long, let
it work on a 8k static buffer with vsnprintf or die loudly.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
18 years ago
|
|
|
static int nfvasprintf(char **strp, const char *fmt, va_list ap)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
char tmp[8192];
|
|
|
|
|
|
|
|
len = vsnprintf(tmp, sizeof(tmp), fmt, ap);
|
|
|
|
if (len < 0)
|
|
|
|
die("Fatal: Out of memory");
|
nfv?asprintf are broken without va_copy, workaround them.
* drop nfasprintf.
* move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
and die() in case of overflow. It should be enough for imap commands, if
someone cares about imap-send, he's welcomed to fix it properly.
* replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
logic, it's one place, we'll live with it.
To ease the change, output_buffer string list is replaced with a strbuf ;)
* rework trace.c to call vsnprintf itself. It's used to format strerror()s
and git command names, it should never be more than a few octets long, let
it work on a 8k static buffer with vsnprintf or die loudly.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
18 years ago
|
|
|
if (len >= sizeof(tmp))
|
|
|
|
die("imap command overflow!");
|
nfv?asprintf are broken without va_copy, workaround them.
* drop nfasprintf.
* move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
and die() in case of overflow. It should be enough for imap commands, if
someone cares about imap-send, he's welcomed to fix it properly.
* replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
logic, it's one place, we'll live with it.
To ease the change, output_buffer string list is replaced with a strbuf ;)
* rework trace.c to call vsnprintf itself. It's used to format strerror()s
and git command names, it should never be more than a few octets long, let
it work on a 8k static buffer with vsnprintf or die loudly.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
18 years ago
|
|
|
*strp = xmemdupz(tmp, len);
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct imap_server_conf {
|
|
|
|
char *name;
|
|
|
|
char *tunnel;
|
|
|
|
char *host;
|
|
|
|
int port;
|
|
|
|
char *user;
|
|
|
|
char *pass;
|
|
|
|
int use_ssl;
|
|
|
|
int ssl_verify;
|
|
|
|
int use_html;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_store_conf {
|
|
|
|
struct store_conf gen;
|
|
|
|
struct imap_server_conf *server;
|
|
|
|
unsigned use_namespace:1;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define NIL (void *)0x1
|
|
|
|
#define LIST (void *)0x2
|
|
|
|
|
|
|
|
struct imap_list {
|
|
|
|
struct imap_list *next, *child;
|
|
|
|
char *val;
|
|
|
|
int len;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_socket {
|
|
|
|
int fd[2];
|
|
|
|
SSL *ssl;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_buffer {
|
|
|
|
struct imap_socket sock;
|
|
|
|
int bytes;
|
|
|
|
int offset;
|
|
|
|
char buf[1024];
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_cmd;
|
|
|
|
|
|
|
|
struct imap {
|
|
|
|
int uidnext; /* from SELECT responses */
|
|
|
|
struct imap_list *ns_personal, *ns_other, *ns_shared; /* NAMESPACE info */
|
|
|
|
unsigned caps, rcaps; /* CAPABILITY results */
|
|
|
|
/* command queue */
|
|
|
|
int nexttag, num_in_progress, literal_pending;
|
|
|
|
struct imap_cmd *in_progress, **in_progress_append;
|
|
|
|
struct imap_buffer buf; /* this is BIG, so put it last */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_store {
|
|
|
|
struct store gen;
|
|
|
|
int uidvalidity;
|
|
|
|
struct imap *imap;
|
|
|
|
const char *prefix;
|
|
|
|
unsigned /*currentnc:1,*/ trashnc:1;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_cmd_cb {
|
|
|
|
int (*cont)(struct imap_store *ctx, struct imap_cmd *cmd, const char *prompt);
|
|
|
|
void (*done)(struct imap_store *ctx, struct imap_cmd *cmd, int response);
|
|
|
|
void *ctx;
|
|
|
|
char *data;
|
|
|
|
int dlen;
|
|
|
|
int uid;
|
|
|
|
unsigned create:1, trycreate:1;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imap_cmd {
|
|
|
|
struct imap_cmd *next;
|
|
|
|
struct imap_cmd_cb cb;
|
|
|
|
char *cmd;
|
|
|
|
int tag;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define CAP(cap) (imap->caps & (1 << (cap)))
|
|
|
|
|
|
|
|
enum CAPABILITY {
|
|
|
|
NOLOGIN = 0,
|
|
|
|
UIDPLUS,
|
|
|
|
LITERALPLUS,
|
|
|
|
NAMESPACE,
|
|
|
|
STARTTLS,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const char *cap_list[] = {
|
|
|
|
"LOGINDISABLED",
|
|
|
|
"UIDPLUS",
|
|
|
|
"LITERAL+",
|
|
|
|
"NAMESPACE",
|
|
|
|
"STARTTLS",
|
|
|
|
};
|
|
|
|
|
|
|
|
#define RESP_OK 0
|
|
|
|
#define RESP_NO 1
|
|
|
|
#define RESP_BAD 2
|
|
|
|
|
|
|
|
static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd);
|
|
|
|
|
|
|
|
|
|
|
|
static const char *Flags[] = {
|
|
|
|
"Draft",
|
|
|
|
"Flagged",
|
|
|
|
"Answered",
|
|
|
|
"Seen",
|
|
|
|
"Deleted",
|
|
|
|
};
|
|
|
|
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
static void ssl_socket_perror(const char *func)
|
|
|
|
{
|
|
|
|
fprintf(stderr, "%s: %s\n", func, ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static void socket_perror(const char *func, struct imap_socket *sock, int ret)
|
|
|
|
{
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
if (sock->ssl) {
|
|
|
|
int sslerr = SSL_get_error(sock->ssl, ret);
|
|
|
|
switch (sslerr) {
|
|
|
|
case SSL_ERROR_NONE:
|
|
|
|
break;
|
|
|
|
case SSL_ERROR_SYSCALL:
|
|
|
|
perror("SSL_connect");
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
ssl_socket_perror("SSL_connect");
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else
|
|
|
|
#endif
|
|
|
|
{
|
|
|
|
if (ret < 0)
|
|
|
|
perror(func);
|
|
|
|
else
|
|
|
|
fprintf(stderr, "%s: unexpected EOF\n", func);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int verify)
|
|
|
|
{
|
|
|
|
#ifdef NO_OPENSSL
|
|
|
|
fprintf(stderr, "SSL requested but SSL support not compiled in\n");
|
|
|
|
return -1;
|
|
|
|
#else
|
|
|
|
#if (OPENSSL_VERSION_NUMBER >= 0x10000000L)
|
|
|
|
const SSL_METHOD *meth;
|
|
|
|
#else
|
|
|
|
SSL_METHOD *meth;
|
|
|
|
#endif
|
|
|
|
SSL_CTX *ctx;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
SSL_library_init();
|
|
|
|
SSL_load_error_strings();
|
|
|
|
|
|
|
|
if (use_tls_only)
|
|
|
|
meth = TLSv1_method();
|
|
|
|
else
|
|
|
|
meth = SSLv23_method();
|
|
|
|
|
|
|
|
if (!meth) {
|
|
|
|
ssl_socket_perror("SSLv23_method");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx = SSL_CTX_new(meth);
|
|
|
|
|
|
|
|
if (verify)
|
|
|
|
SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);
|
|
|
|
|
|
|
|
if (!SSL_CTX_set_default_verify_paths(ctx)) {
|
|
|
|
ssl_socket_perror("SSL_CTX_set_default_verify_paths");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
sock->ssl = SSL_new(ctx);
|
|
|
|
if (!sock->ssl) {
|
|
|
|
ssl_socket_perror("SSL_new");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (!SSL_set_rfd(sock->ssl, sock->fd[0])) {
|
|
|
|
ssl_socket_perror("SSL_set_rfd");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (!SSL_set_wfd(sock->ssl, sock->fd[1])) {
|
|
|
|
ssl_socket_perror("SSL_set_wfd");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = SSL_connect(sock->ssl);
|
|
|
|
if (ret <= 0) {
|
|
|
|
socket_perror("SSL_connect", sock, ret);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
static int socket_read(struct imap_socket *sock, char *buf, int len)
|
|
|
|
{
|
|
|
|
ssize_t n;
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
if (sock->ssl)
|
|
|
|
n = SSL_read(sock->ssl, buf, len);
|
|
|
|
else
|
|
|
|
#endif
|
|
|
|
n = xread(sock->fd[0], buf, len);
|
|
|
|
if (n <= 0) {
|
|
|
|
socket_perror("read", sock, n);
|
|
|
|
close(sock->fd[0]);
|
|
|
|
close(sock->fd[1]);
|
|
|
|
sock->fd[0] = sock->fd[1] = -1;
|
|
|
|
}
|
|
|
|
return n;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int socket_write(struct imap_socket *sock, const char *buf, int len)
|
|
|
|
{
|
|
|
|
int n;
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
if (sock->ssl)
|
|
|
|
n = SSL_write(sock->ssl, buf, len);
|
|
|
|
else
|
|
|
|
#endif
|
|
|
|
n = write_in_full(sock->fd[1], buf, len);
|
|
|
|
if (n != len) {
|
|
|
|
socket_perror("write", sock, n);
|
|
|
|
close(sock->fd[0]);
|
|
|
|
close(sock->fd[1]);
|
|
|
|
sock->fd[0] = sock->fd[1] = -1;
|
|
|
|
}
|
|
|
|
return n;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void socket_shutdown(struct imap_socket *sock)
|
|
|
|
{
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
if (sock->ssl) {
|
|
|
|
SSL_shutdown(sock->ssl);
|
|
|
|
SSL_free(sock->ssl);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
close(sock->fd[0]);
|
|
|
|
close(sock->fd[1]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* simple line buffering */
|
|
|
|
static int buffer_gets(struct imap_buffer *b, char **s)
|
|
|
|
{
|
|
|
|
int n;
|
|
|
|
int start = b->offset;
|
|
|
|
|
|
|
|
*s = b->buf + start;
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
/* make sure we have enough data to read the \r\n sequence */
|
|
|
|
if (b->offset + 1 >= b->bytes) {
|
|
|
|
if (start) {
|
|
|
|
/* shift down used bytes */
|
|
|
|
*s = b->buf;
|
|
|
|
|
|
|
|
assert(start <= b->bytes);
|
|
|
|
n = b->bytes - start;
|
|
|
|
|
|
|
|
if (n)
|
|
|
|
memmove(b->buf, b->buf + start, n);
|
|
|
|
b->offset -= start;
|
|
|
|
b->bytes = n;
|
|
|
|
start = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
n = socket_read(&b->sock, b->buf + b->bytes,
|
|
|
|
sizeof(b->buf) - b->bytes);
|
|
|
|
|
|
|
|
if (n <= 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
b->bytes += n;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (b->buf[b->offset] == '\r') {
|
|
|
|
assert(b->offset + 1 < b->bytes);
|
|
|
|
if (b->buf[b->offset + 1] == '\n') {
|
|
|
|
b->buf[b->offset] = 0; /* terminate the string */
|
|
|
|
b->offset += 2; /* next line */
|
|
|
|
if (Verbose)
|
|
|
|
puts(*s);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
b->offset++;
|
|
|
|
}
|
|
|
|
/* not reached */
|
|
|
|
}
|
|
|
|
|
|
|
|
static void imap_info(const char *msg, ...)
|
|
|
|
{
|
|
|
|
va_list va;
|
|
|
|
|
|
|
|
if (!Quiet) {
|
|
|
|
va_start(va, msg);
|
|
|
|
vprintf(msg, va);
|
|
|
|
va_end(va);
|
|
|
|
fflush(stdout);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void imap_warn(const char *msg, ...)
|
|
|
|
{
|
|
|
|
va_list va;
|
|
|
|
|
|
|
|
if (Quiet < 2) {
|
|
|
|
va_start(va, msg);
|
|
|
|
vfprintf(stderr, msg, va);
|
|
|
|
va_end(va);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static char *next_arg(char **s)
|
|
|
|
{
|
|
|
|
char *ret;
|
|
|
|
|
|
|
|
if (!s || !*s)
|
|
|
|
return NULL;
|
|
|
|
while (isspace((unsigned char) **s))
|
|
|
|
(*s)++;
|
|
|
|
if (!**s) {
|
|
|
|
*s = NULL;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
if (**s == '"') {
|
|
|
|
++*s;
|
|
|
|
ret = *s;
|
|
|
|
*s = strchr(*s, '"');
|
|
|
|
} else {
|
|
|
|
ret = *s;
|
|
|
|
while (**s && !isspace((unsigned char) **s))
|
|
|
|
(*s)++;
|
|
|
|
}
|
|
|
|
if (*s) {
|
|
|
|
if (**s)
|
|
|
|
*(*s)++ = 0;
|
|
|
|
if (!**s)
|
|
|
|
*s = NULL;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void free_generic_messages(struct message *msgs)
|
|
|
|
{
|
|
|
|
struct message *tmsg;
|
|
|
|
|
|
|
|
for (; msgs; msgs = tmsg) {
|
|
|
|
tmsg = msgs->next;
|
|
|
|
free(msgs);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nfsnprintf(char *buf, int blen, const char *fmt, ...)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
va_list va;
|
|
|
|
|
|
|
|
va_start(va, fmt);
|
|
|
|
if (blen <= 0 || (unsigned)(ret = vsnprintf(buf, blen, fmt, va)) >= (unsigned)blen)
|
|
|
|
die("Fatal: buffer too small. Please report a bug.");
|
|
|
|
va_end(va);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct imap_cmd *v_issue_imap_cmd(struct imap_store *ctx,
|
|
|
|
struct imap_cmd_cb *cb,
|
|
|
|
const char *fmt, va_list ap)
|
|
|
|
{
|
|
|
|
struct imap *imap = ctx->imap;
|
|
|
|
struct imap_cmd *cmd;
|
|
|
|
int n, bufl;
|
|
|
|
char buf[1024];
|
|
|
|
|
|
|
|
cmd = xmalloc(sizeof(struct imap_cmd));
|
|
|
|
nfvasprintf(&cmd->cmd, fmt, ap);
|
|
|
|
cmd->tag = ++imap->nexttag;
|
|
|
|
|
|
|
|
if (cb)
|
|
|
|
cmd->cb = *cb;
|
|
|
|
else
|
|
|
|
memset(&cmd->cb, 0, sizeof(cmd->cb));
|
|
|
|
|
|
|
|
while (imap->literal_pending)
|
|
|
|
get_cmd_result(ctx, NULL);
|
|
|
|
|
|
|
|
bufl = nfsnprintf(buf, sizeof(buf), cmd->cb.data ? CAP(LITERALPLUS) ?
|
|
|
|
"%d %s{%d+}\r\n" : "%d %s{%d}\r\n" : "%d %s\r\n",
|
|
|
|
cmd->tag, cmd->cmd, cmd->cb.dlen);
|
|
|
|
if (Verbose) {
|
|
|
|
if (imap->num_in_progress)
|
|
|
|
printf("(%d in progress) ", imap->num_in_progress);
|
|
|
|
if (memcmp(cmd->cmd, "LOGIN", 5))
|
|
|
|
printf(">>> %s", buf);
|
|
|
|
else
|
|
|
|
printf(">>> %d LOGIN <user> <pass>\n", cmd->tag);
|
|
|
|
}
|
|
|
|
if (socket_write(&imap->buf.sock, buf, bufl) != bufl) {
|
|
|
|
free(cmd->cmd);
|
|
|
|
free(cmd);
|
Avoid unnecessary "if-before-free" tests.
This change removes all obvious useless if-before-free tests.
E.g., it replaces code like this:
if (some_expression)
free (some_expression);
with the now-equivalent:
free (some_expression);
It is equivalent not just because POSIX has required free(NULL)
to work for a long time, but simply because it has worked for
so long that no reasonable porting target fails the test.
Here's some evidence from nearly 1.5 years ago:
http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html
FYI, the change below was prepared by running the following:
git ls-files -z | xargs -0 \
perl -0x3b -pi -e \
's/\bif\s*\(\s*(\S+?)(?:\s*!=\s*NULL)?\s*\)\s+(free\s*\(\s*\1\s*\))/$2/s'
Note however, that it doesn't handle brace-enclosed blocks like
"if (x) { free (x); }". But that's ok, since there were none like
that in git sources.
Beware: if you do use the above snippet, note that it can
produce syntactically invalid C code. That happens when the
affected "if"-statement has a matching "else".
E.g., it would transform this
if (x)
free (x);
else
foo ();
into this:
free (x);
else
foo ();
There were none of those here, either.
If you're interested in automating detection of the useless
tests, you might like the useless-if-before-free script in gnulib:
[it *does* detect brace-enclosed free statements, and has a --name=S
option to make it detect free-like functions with different names]
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=build-aux/useless-if-before-free
Addendum:
Remove one more (in imap-send.c), spotted by Jean-Luc Herren <jlh@gmx.ch>.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
17 years ago
|
|
|
if (cb)
|
|
|
|
free(cb->data);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
if (cmd->cb.data) {
|
|
|
|
if (CAP(LITERALPLUS)) {
|
|
|
|
n = socket_write(&imap->buf.sock, cmd->cb.data, cmd->cb.dlen);
|
|
|
|
free(cmd->cb.data);
|
|
|
|
if (n != cmd->cb.dlen ||
|
|
|
|
socket_write(&imap->buf.sock, "\r\n", 2) != 2) {
|
|
|
|
free(cmd->cmd);
|
|
|
|
free(cmd);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
cmd->cb.data = NULL;
|
|
|
|
} else
|
|
|
|
imap->literal_pending = 1;
|
|
|
|
} else if (cmd->cb.cont)
|
|
|
|
imap->literal_pending = 1;
|
|
|
|
cmd->next = NULL;
|
|
|
|
*imap->in_progress_append = cmd;
|
|
|
|
imap->in_progress_append = &cmd->next;
|
|
|
|
imap->num_in_progress++;
|
|
|
|
return cmd;
|
|
|
|
}
|
|
|
|
|
|
|
|
__attribute__((format (printf, 3, 4)))
|
|
|
|
static struct imap_cmd *issue_imap_cmd(struct imap_store *ctx,
|
|
|
|
struct imap_cmd_cb *cb,
|
|
|
|
const char *fmt, ...)
|
|
|
|
{
|
|
|
|
struct imap_cmd *ret;
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
ret = v_issue_imap_cmd(ctx, cb, fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
__attribute__((format (printf, 3, 4)))
|
|
|
|
static int imap_exec(struct imap_store *ctx, struct imap_cmd_cb *cb,
|
|
|
|
const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
struct imap_cmd *cmdp;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
cmdp = v_issue_imap_cmd(ctx, cb, fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
if (!cmdp)
|
|
|
|
return RESP_BAD;
|
|
|
|
|
|
|
|
return get_cmd_result(ctx, cmdp);
|
|
|
|
}
|
|
|
|
|
|
|
|
__attribute__((format (printf, 3, 4)))
|
|
|
|
static int imap_exec_m(struct imap_store *ctx, struct imap_cmd_cb *cb,
|
|
|
|
const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
struct imap_cmd *cmdp;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
cmdp = v_issue_imap_cmd(ctx, cb, fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
if (!cmdp)
|
|
|
|
return DRV_STORE_BAD;
|
|
|
|
|
|
|
|
switch (get_cmd_result(ctx, cmdp)) {
|
|
|
|
case RESP_BAD: return DRV_STORE_BAD;
|
|
|
|
case RESP_NO: return DRV_MSG_BAD;
|
|
|
|
default: return DRV_OK;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_atom(struct imap_list *list)
|
|
|
|
{
|
|
|
|
return list && list->val && list->val != NIL && list->val != LIST;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_list(struct imap_list *list)
|
|
|
|
{
|
|
|
|
return list && list->val == LIST;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void free_list(struct imap_list *list)
|
|
|
|
{
|
|
|
|
struct imap_list *tmp;
|
|
|
|
|
|
|
|
for (; list; list = tmp) {
|
|
|
|
tmp = list->next;
|
|
|
|
if (is_list(list))
|
|
|
|
free_list(list->child);
|
|
|
|
else if (is_atom(list))
|
|
|
|
free(list->val);
|
|
|
|
free(list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_imap_list_l(struct imap *imap, char **sp, struct imap_list **curp, int level)
|
|
|
|
{
|
|
|
|
struct imap_list *cur;
|
|
|
|
char *s = *sp, *p;
|
|
|
|
int n, bytes;
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
while (isspace((unsigned char)*s))
|
|
|
|
s++;
|
|
|
|
if (level && *s == ')') {
|
|
|
|
s++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
*curp = cur = xmalloc(sizeof(*cur));
|
|
|
|
curp = &cur->next;
|
|
|
|
cur->val = NULL; /* for clean bail */
|
|
|
|
if (*s == '(') {
|
|
|
|
/* sublist */
|
|
|
|
s++;
|
|
|
|
cur->val = LIST;
|
|
|
|
if (parse_imap_list_l(imap, &s, &cur->child, level + 1))
|
|
|
|
goto bail;
|
|
|
|
} else if (imap && *s == '{') {
|
|
|
|
/* literal */
|
|
|
|
bytes = cur->len = strtol(s + 1, &s, 10);
|
|
|
|
if (*s != '}')
|
|
|
|
goto bail;
|
|
|
|
|
|
|
|
s = cur->val = xmalloc(cur->len);
|
|
|
|
|
|
|
|
/* dump whats left over in the input buffer */
|
|
|
|
n = imap->buf.bytes - imap->buf.offset;
|
|
|
|
|
|
|
|
if (n > bytes)
|
|
|
|
/* the entire message fit in the buffer */
|
|
|
|
n = bytes;
|
|
|
|
|
|
|
|
memcpy(s, imap->buf.buf + imap->buf.offset, n);
|
|
|
|
s += n;
|
|
|
|
bytes -= n;
|
|
|
|
|
|
|
|
/* mark that we used part of the buffer */
|
|
|
|
imap->buf.offset += n;
|
|
|
|
|
|
|
|
/* now read the rest of the message */
|
|
|
|
while (bytes > 0) {
|
|
|
|
if ((n = socket_read(&imap->buf.sock, s, bytes)) <= 0)
|
|
|
|
goto bail;
|
|
|
|
s += n;
|
|
|
|
bytes -= n;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (buffer_gets(&imap->buf, &s))
|
|
|
|
goto bail;
|
|
|
|
} else if (*s == '"') {
|
|
|
|
/* quoted string */
|
|
|
|
s++;
|
|
|
|
p = s;
|
|
|
|
for (; *s != '"'; s++)
|
|
|
|
if (!*s)
|
|
|
|
goto bail;
|
|
|
|
cur->len = s - p;
|
|
|
|
s++;
|
|
|
|
cur->val = xmemdupz(p, cur->len);
|
|
|
|
} else {
|
|
|
|
/* atom */
|
|
|
|
p = s;
|
|
|
|
for (; *s && !isspace((unsigned char)*s); s++)
|
|
|
|
if (level && *s == ')')
|
|
|
|
break;
|
|
|
|
cur->len = s - p;
|
|
|
|
if (cur->len == 3 && !memcmp("NIL", p, 3))
|
|
|
|
cur->val = NIL;
|
|
|
|
else
|
|
|
|
cur->val = xmemdupz(p, cur->len);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!level)
|
|
|
|
break;
|
|
|
|
if (!*s)
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
*sp = s;
|
|
|
|
*curp = NULL;
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
bail:
|
|
|
|
*curp = NULL;
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct imap_list *parse_imap_list(struct imap *imap, char **sp)
|
|
|
|
{
|
|
|
|
struct imap_list *head;
|
|
|
|
|
|
|
|
if (!parse_imap_list_l(imap, sp, &head, 0))
|
|
|
|
return head;
|
|
|
|
free_list(head);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct imap_list *parse_list(char **sp)
|
|
|
|
{
|
|
|
|
return parse_imap_list(NULL, sp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void parse_capability(struct imap *imap, char *cmd)
|
|
|
|
{
|
|
|
|
char *arg;
|
|
|
|
unsigned i;
|
|
|
|
|
|
|
|
imap->caps = 0x80000000;
|
|
|
|
while ((arg = next_arg(&cmd)))
|
|
|
|
for (i = 0; i < ARRAY_SIZE(cap_list); i++)
|
|
|
|
if (!strcmp(cap_list[i], arg))
|
|
|
|
imap->caps |= 1 << i;
|
|
|
|
imap->rcaps = imap->caps;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_response_code(struct imap_store *ctx, struct imap_cmd_cb *cb,
|
|
|
|
char *s)
|
|
|
|
{
|
|
|
|
struct imap *imap = ctx->imap;
|
|
|
|
char *arg, *p;
|
|
|
|
|
|
|
|
if (*s != '[')
|
|
|
|
return RESP_OK; /* no response code */
|
|
|
|
s++;
|
|
|
|
if (!(p = strchr(s, ']'))) {
|
|
|
|
fprintf(stderr, "IMAP error: malformed response code\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
*p++ = 0;
|
|
|
|
arg = next_arg(&s);
|
|
|
|
if (!strcmp("UIDVALIDITY", arg)) {
|
|
|
|
if (!(arg = next_arg(&s)) || !(ctx->gen.uidvalidity = atoi(arg))) {
|
|
|
|
fprintf(stderr, "IMAP error: malformed UIDVALIDITY status\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
} else if (!strcmp("UIDNEXT", arg)) {
|
|
|
|
if (!(arg = next_arg(&s)) || !(imap->uidnext = atoi(arg))) {
|
|
|
|
fprintf(stderr, "IMAP error: malformed NEXTUID status\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
} else if (!strcmp("CAPABILITY", arg)) {
|
|
|
|
parse_capability(imap, s);
|
|
|
|
} else if (!strcmp("ALERT", arg)) {
|
|
|
|
/* RFC2060 says that these messages MUST be displayed
|
|
|
|
* to the user
|
|
|
|
*/
|
|
|
|
for (; isspace((unsigned char)*p); p++);
|
|
|
|
fprintf(stderr, "*** IMAP ALERT *** %s\n", p);
|
|
|
|
} else if (cb && cb->ctx && !strcmp("APPENDUID", arg)) {
|
|
|
|
if (!(arg = next_arg(&s)) || !(ctx->gen.uidvalidity = atoi(arg)) ||
|
|
|
|
!(arg = next_arg(&s)) || !(*(int *)cb->ctx = atoi(arg))) {
|
|
|
|
fprintf(stderr, "IMAP error: malformed APPENDUID status\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return RESP_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
|
|
|
|
{
|
|
|
|
struct imap *imap = ctx->imap;
|
|
|
|
struct imap_cmd *cmdp, **pcmdp, *ncmdp;
|
|
|
|
char *cmd, *arg, *arg1, *p;
|
|
|
|
int n, resp, resp2, tag;
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
if (buffer_gets(&imap->buf, &cmd))
|
|
|
|
return RESP_BAD;
|
|
|
|
|
|
|
|
arg = next_arg(&cmd);
|
|
|
|
if (*arg == '*') {
|
|
|
|
arg = next_arg(&cmd);
|
|
|
|
if (!arg) {
|
|
|
|
fprintf(stderr, "IMAP error: unable to parse untagged response\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp("NAMESPACE", arg)) {
|
|
|
|
imap->ns_personal = parse_list(&cmd);
|
|
|
|
imap->ns_other = parse_list(&cmd);
|
|
|
|
imap->ns_shared = parse_list(&cmd);
|
|
|
|
} else if (!strcmp("OK", arg) || !strcmp("BAD", arg) ||
|
|
|
|
!strcmp("NO", arg) || !strcmp("BYE", arg)) {
|
|
|
|
if ((resp = parse_response_code(ctx, NULL, cmd)) != RESP_OK)
|
|
|
|
return resp;
|
|
|
|
} else if (!strcmp("CAPABILITY", arg))
|
|
|
|
parse_capability(imap, cmd);
|
|
|
|
else if ((arg1 = next_arg(&cmd))) {
|
|
|
|
if (!strcmp("EXISTS", arg1))
|
|
|
|
ctx->gen.count = atoi(arg);
|
|
|
|
else if (!strcmp("RECENT", arg1))
|
|
|
|
ctx->gen.recent = atoi(arg);
|
|
|
|
} else {
|
|
|
|
fprintf(stderr, "IMAP error: unable to parse untagged response\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
} else if (!imap->in_progress) {
|
|
|
|
fprintf(stderr, "IMAP error: unexpected reply: %s %s\n", arg, cmd ? cmd : "");
|
|
|
|
return RESP_BAD;
|
|
|
|
} else if (*arg == '+') {
|
|
|
|
/* This can happen only with the last command underway, as
|
|
|
|
it enforces a round-trip. */
|
|
|
|
cmdp = (struct imap_cmd *)((char *)imap->in_progress_append -
|
|
|
|
offsetof(struct imap_cmd, next));
|
|
|
|
if (cmdp->cb.data) {
|
|
|
|
n = socket_write(&imap->buf.sock, cmdp->cb.data, cmdp->cb.dlen);
|
|
|
|
free(cmdp->cb.data);
|
|
|
|
cmdp->cb.data = NULL;
|
|
|
|
if (n != (int)cmdp->cb.dlen)
|
|
|
|
return RESP_BAD;
|
|
|
|
} else if (cmdp->cb.cont) {
|
|
|
|
if (cmdp->cb.cont(ctx, cmdp, cmd))
|
|
|
|
return RESP_BAD;
|
|
|
|
} else {
|
|
|
|
fprintf(stderr, "IMAP error: unexpected command continuation request\n");
|
|
|
|
return RESP_BAD;
|
|
|
|
}
|
|
|
|
if (socket_write(&imap->buf.sock, "\r\n", 2) != 2)
|
|
|
|
return RESP_BAD;
|
|
|
|
if (!cmdp->cb.cont)
|
|
|
|
imap->literal_pending = 0;
|
|
|
|
if (!tcmd)
|
|
|
|
return DRV_OK;
|
|
|
|
} else {
|
|
|
|
tag = atoi(arg);
|
|
|
|
for (pcmdp = &imap->in_progress; (cmdp = *pcmdp); pcmdp = &cmdp->next)
|
|
|
|
if (cmdp->tag == tag)
|
|
|
|
goto gottag;
|
|
|
|
fprintf(stderr, "IMAP error: unexpected tag %s\n", arg);
|
|
|
|
return RESP_BAD;
|
|
|
|
gottag:
|
|
|
|
if (!(*pcmdp = cmdp->next))
|
|
|
|
imap->in_progress_append = pcmdp;
|
|
|
|
imap->num_in_progress--;
|
|
|
|
if (cmdp->cb.cont || cmdp->cb.data)
|
|
|
|
imap->literal_pending = 0;
|
|
|
|
arg = next_arg(&cmd);
|
|
|
|
if (!strcmp("OK", arg))
|
|
|
|
resp = DRV_OK;
|
|
|
|
else {
|
|
|
|
if (!strcmp("NO", arg)) {
|
|
|
|
if (cmdp->cb.create && cmd && (cmdp->cb.trycreate || !memcmp(cmd, "[TRYCREATE]", 11))) { /* SELECT, APPEND or UID COPY */
|
|
|
|
p = strchr(cmdp->cmd, '"');
|
|
|
|
if (!issue_imap_cmd(ctx, NULL, "CREATE \"%.*s\"", (int)(strchr(p + 1, '"') - p + 1), p)) {
|
|
|
|
resp = RESP_BAD;
|
|
|
|
goto normal;
|
|
|
|
}
|
|
|
|
/* not waiting here violates the spec, but a server that does not
|
|
|
|
grok this nonetheless violates it too. */
|
|
|
|
cmdp->cb.create = 0;
|
|
|
|
if (!(ncmdp = issue_imap_cmd(ctx, &cmdp->cb, "%s", cmdp->cmd))) {
|
|
|
|
resp = RESP_BAD;
|
|
|
|
goto normal;
|
|
|
|
}
|
|
|
|
free(cmdp->cmd);
|
|
|
|
free(cmdp);
|
|
|
|
if (!tcmd)
|
|
|
|
return 0; /* ignored */
|
|
|
|
if (cmdp == tcmd)
|
|
|
|
tcmd = ncmdp;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
resp = RESP_NO;
|
|
|
|
} else /*if (!strcmp("BAD", arg))*/
|
|
|
|
resp = RESP_BAD;
|
|
|
|
fprintf(stderr, "IMAP command '%s' returned response (%s) - %s\n",
|
|
|
|
memcmp(cmdp->cmd, "LOGIN", 5) ?
|
|
|
|
cmdp->cmd : "LOGIN <user> <pass>",
|
|
|
|
arg, cmd ? cmd : "");
|
|
|
|
}
|
|
|
|
if ((resp2 = parse_response_code(ctx, &cmdp->cb, cmd)) > resp)
|
|
|
|
resp = resp2;
|
|
|
|
normal:
|
|
|
|
if (cmdp->cb.done)
|
|
|
|
cmdp->cb.done(ctx, cmdp, resp);
|
|
|
|
free(cmdp->cb.data);
|
|
|
|
free(cmdp->cmd);
|
|
|
|
free(cmdp);
|
|
|
|
if (!tcmd || tcmd == cmdp)
|
|
|
|
return resp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/* not reached */
|
|
|
|
}
|
|
|
|
|
|
|
|
static void imap_close_server(struct imap_store *ictx)
|
|
|
|
{
|
|
|
|
struct imap *imap = ictx->imap;
|
|
|
|
|
|
|
|
if (imap->buf.sock.fd[0] != -1) {
|
|
|
|
imap_exec(ictx, NULL, "LOGOUT");
|
|
|
|
socket_shutdown(&imap->buf.sock);
|
|
|
|
}
|
|
|
|
free_list(imap->ns_personal);
|
|
|
|
free_list(imap->ns_other);
|
|
|
|
free_list(imap->ns_shared);
|
|
|
|
free(imap);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void imap_close_store(struct store *ctx)
|
|
|
|
{
|
|
|
|
imap_close_server((struct imap_store *)ctx);
|
|
|
|
free_generic_messages(ctx->msgs);
|
|
|
|
free(ctx);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct store *imap_open_store(struct imap_server_conf *srvc)
|
|
|
|
{
|
|
|
|
struct imap_store *ctx;
|
|
|
|
struct imap *imap;
|
|
|
|
char *arg, *rsp;
|
|
|
|
int s = -1, preauth;
|
|
|
|
|
|
|
|
ctx = xcalloc(sizeof(*ctx), 1);
|
|
|
|
|
|
|
|
ctx->imap = imap = xcalloc(sizeof(*imap), 1);
|
|
|
|
imap->buf.sock.fd[0] = imap->buf.sock.fd[1] = -1;
|
|
|
|
imap->in_progress_append = &imap->in_progress;
|
|
|
|
|
|
|
|
/* open connection to IMAP server */
|
|
|
|
|
|
|
|
if (srvc->tunnel) {
|
|
|
|
const char *argv[4];
|
|
|
|
struct child_process tunnel = {0};
|
|
|
|
|
|
|
|
imap_info("Starting tunnel '%s'... ", srvc->tunnel);
|
|
|
|
|
|
|
|
argv[0] = "sh";
|
|
|
|
argv[1] = "-c";
|
|
|
|
argv[2] = srvc->tunnel;
|
|
|
|
argv[3] = NULL;
|
|
|
|
|
|
|
|
tunnel.argv = argv;
|
|
|
|
tunnel.in = -1;
|
|
|
|
tunnel.out = -1;
|
|
|
|
if (start_command(&tunnel))
|
|
|
|
die("cannot start proxy %s", argv[0]);
|
|
|
|
|
|
|
|
imap->buf.sock.fd[0] = tunnel.out;
|
|
|
|
imap->buf.sock.fd[1] = tunnel.in;
|
|
|
|
|
|
|
|
imap_info("ok\n");
|
|
|
|
} else {
|
|
|
|
#ifndef NO_IPV6
|
|
|
|
struct addrinfo hints, *ai0, *ai;
|
|
|
|
int gai;
|
|
|
|
char portstr[6];
|
|
|
|
|
|
|
|
snprintf(portstr, sizeof(portstr), "%hu", srvc->port);
|
|
|
|
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
|
|
hints.ai_socktype = SOCK_STREAM;
|
|
|
|
hints.ai_protocol = IPPROTO_TCP;
|
|
|
|
|
|
|
|
imap_info("Resolving %s... ", srvc->host);
|
|
|
|
gai = getaddrinfo(srvc->host, portstr, &hints, &ai);
|
|
|
|
if (gai) {
|
|
|
|
fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(gai));
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
imap_info("ok\n");
|
|
|
|
|
|
|
|
for (ai0 = ai; ai; ai = ai->ai_next) {
|
|
|
|
char addr[NI_MAXHOST];
|
|
|
|
|
|
|
|
s = socket(ai->ai_family, ai->ai_socktype,
|
|
|
|
ai->ai_protocol);
|
|
|
|
if (s < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
getnameinfo(ai->ai_addr, ai->ai_addrlen, addr,
|
|
|
|
sizeof(addr), NULL, 0, NI_NUMERICHOST);
|
|
|
|
imap_info("Connecting to [%s]:%s... ", addr, portstr);
|
|
|
|
|
|
|
|
if (connect(s, ai->ai_addr, ai->ai_addrlen) < 0) {
|
|
|
|
close(s);
|
|
|
|
s = -1;
|
|
|
|
perror("connect");
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
freeaddrinfo(ai0);
|
|
|
|
#else /* NO_IPV6 */
|
|
|
|
struct hostent *he;
|
|
|
|
struct sockaddr_in addr;
|
|
|
|
|
|
|
|
memset(&addr, 0, sizeof(addr));
|
|
|
|
addr.sin_port = htons(srvc->port);
|
|
|
|
addr.sin_family = AF_INET;
|
|
|
|
|
|
|
|
imap_info("Resolving %s... ", srvc->host);
|
|
|
|
he = gethostbyname(srvc->host);
|
|
|
|
if (!he) {
|
|
|
|
perror("gethostbyname");
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
imap_info("ok\n");
|
|
|
|
|
|
|
|
addr.sin_addr.s_addr = *((int *) he->h_addr_list[0]);
|
|
|
|
|
|
|
|
s = socket(PF_INET, SOCK_STREAM, 0);
|
|
|
|
|
|
|
|
imap_info("Connecting to %s:%hu... ", inet_ntoa(addr.sin_addr), ntohs(addr.sin_port));
|
|
|
|
if (connect(s, (struct sockaddr *)&addr, sizeof(addr))) {
|
|
|
|
close(s);
|
|
|
|
s = -1;
|
|
|
|
perror("connect");
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
if (s < 0) {
|
|
|
|
fputs("Error: unable to connect to server.\n", stderr);
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
|
|
|
|
imap->buf.sock.fd[0] = s;
|
|
|
|
imap->buf.sock.fd[1] = dup(s);
|
|
|
|
|
|
|
|
if (srvc->use_ssl &&
|
|
|
|
ssl_socket_connect(&imap->buf.sock, 0, srvc->ssl_verify)) {
|
|
|
|
close(s);
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
imap_info("ok\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
/* read the greeting string */
|
|
|
|
if (buffer_gets(&imap->buf, &rsp)) {
|
|
|
|
fprintf(stderr, "IMAP error: no greeting response\n");
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
arg = next_arg(&rsp);
|
|
|
|
if (!arg || *arg != '*' || (arg = next_arg(&rsp)) == NULL) {
|
|
|
|
fprintf(stderr, "IMAP error: invalid greeting response\n");
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
preauth = 0;
|
|
|
|
if (!strcmp("PREAUTH", arg))
|
|
|
|
preauth = 1;
|
|
|
|
else if (strcmp("OK", arg) != 0) {
|
|
|
|
fprintf(stderr, "IMAP error: unknown greeting response\n");
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
parse_response_code(ctx, NULL, rsp);
|
|
|
|
if (!imap->caps && imap_exec(ctx, NULL, "CAPABILITY") != RESP_OK)
|
|
|
|
goto bail;
|
|
|
|
|
|
|
|
if (!preauth) {
|
|
|
|
#ifndef NO_OPENSSL
|
|
|
|
if (!srvc->use_ssl && CAP(STARTTLS)) {
|
|
|
|
if (imap_exec(ctx, 0, "STARTTLS") != RESP_OK)
|
|
|
|
goto bail;
|
|
|
|
if (ssl_socket_connect(&imap->buf.sock, 1,
|
|
|
|
srvc->ssl_verify))
|
|
|
|
goto bail;
|
|
|
|
/* capabilities may have changed, so get the new capabilities */
|
|
|
|
if (imap_exec(ctx, 0, "CAPABILITY") != RESP_OK)
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
imap_info("Logging in...\n");
|
|
|
|
if (!srvc->user) {
|
|
|
|
fprintf(stderr, "Skipping server %s, no user\n", srvc->host);
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
if (!srvc->pass) {
|
|
|
|
char prompt[80];
|
|
|
|
sprintf(prompt, "Password (%s@%s): ", srvc->user, srvc->host);
|
|
|
|
arg = getpass(prompt);
|
|
|
|
if (!arg) {
|
|
|
|
perror("getpass");
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
if (!*arg) {
|
|
|
|
fprintf(stderr, "Skipping account %s@%s, no password\n", srvc->user, srvc->host);
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* getpass() returns a pointer to a static buffer. make a copy
|
|
|
|
* for long term storage.
|
|
|
|
*/
|
|
|
|
srvc->pass = xstrdup(arg);
|
|
|
|
}
|
|
|
|
if (CAP(NOLOGIN)) {
|
|
|
|
fprintf(stderr, "Skipping account %s@%s, server forbids LOGIN\n", srvc->user, srvc->host);
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
if (!imap->buf.sock.ssl)
|
|
|
|
imap_warn("*** IMAP Warning *** Password is being "
|
|
|
|
"sent in the clear\n");
|
|
|
|
if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user, srvc->pass) != RESP_OK) {
|
|
|
|
fprintf(stderr, "IMAP error: LOGIN failed\n");
|
|
|
|
goto bail;
|
|
|
|
}
|
|
|
|
} /* !preauth */
|
|
|
|
|
|
|
|
ctx->prefix = "";
|
|
|
|
ctx->trashnc = 1;
|
|
|
|
return (struct store *)ctx;
|
|
|
|
|
|
|
|
bail:
|
|
|
|
imap_close_store(&ctx->gen);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imap_make_flags(int flags, char *buf)
|
|
|
|
{
|
|
|
|
const char *s;
|
|
|
|
unsigned i, d;
|
|
|
|
|
|
|
|
for (i = d = 0; i < ARRAY_SIZE(Flags); i++)
|
|
|
|
if (flags & (1 << i)) {
|
|
|
|
buf[d++] = ' ';
|
|
|
|
buf[d++] = '\\';
|
|
|
|
for (s = Flags[i]; *s; s++)
|
|
|
|
buf[d++] = *s;
|
|
|
|
}
|
|
|
|
buf[0] = '(';
|
|
|
|
buf[d++] = ')';
|
|
|
|
return d;
|
|
|
|
}
|
|
|
|
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
static int imap_store_msg(struct store *gctx, struct msg_data *data)
|
|
|
|
{
|
|
|
|
struct imap_store *ctx = (struct imap_store *)gctx;
|
|
|
|
struct imap *imap = ctx->imap;
|
|
|
|
struct imap_cmd_cb cb;
|
|
|
|
const char *prefix, *box;
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
int ret, d;
|
|
|
|
char flagstr[128];
|
|
|
|
|
|
|
|
memset(&cb, 0, sizeof(cb));
|
|
|
|
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
cb.dlen = data->len;
|
|
|
|
cb.data = xmalloc(cb.dlen);
|
|
|
|
memcpy(cb.data, data->data, data->len);
|
|
|
|
|
|
|
|
d = 0;
|
|
|
|
if (data->flags) {
|
|
|
|
d = imap_make_flags(data->flags, flagstr);
|
|
|
|
flagstr[d++] = ' ';
|
|
|
|
}
|
|
|
|
flagstr[d] = 0;
|
|
|
|
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
box = gctx->name;
|
|
|
|
prefix = !strcmp(box, "INBOX") ? "" : ctx->prefix;
|
|
|
|
cb.create = 0;
|
|
|
|
ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\" %s", prefix, box, flagstr);
|
|
|
|
imap->caps = imap->rcaps;
|
|
|
|
if (ret != DRV_OK)
|
|
|
|
return ret;
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
gctx->count++;
|
|
|
|
|
|
|
|
return DRV_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void encode_html_chars(struct strbuf *p)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < p->len; i++) {
|
|
|
|
if (p->buf[i] == '&')
|
|
|
|
strbuf_splice(p, i, 1, "&", 5);
|
|
|
|
if (p->buf[i] == '<')
|
|
|
|
strbuf_splice(p, i, 1, "<", 4);
|
|
|
|
if (p->buf[i] == '>')
|
|
|
|
strbuf_splice(p, i, 1, ">", 4);
|
|
|
|
if (p->buf[i] == '"')
|
|
|
|
strbuf_splice(p, i, 1, """, 6);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
static void wrap_in_html(struct msg_data *msg)
|
|
|
|
{
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
struct strbuf **lines;
|
|
|
|
struct strbuf **p;
|
|
|
|
static char *content_type = "Content-Type: text/html;\n";
|
|
|
|
static char *pre_open = "<pre>\n";
|
|
|
|
static char *pre_close = "</pre>\n";
|
|
|
|
int added_header = 0;
|
|
|
|
|
|
|
|
strbuf_attach(&buf, msg->data, msg->len, msg->len);
|
|
|
|
lines = strbuf_split(&buf, '\n');
|
|
|
|
strbuf_release(&buf);
|
|
|
|
for (p = lines; *p; p++) {
|
|
|
|
if (! added_header) {
|
|
|
|
if ((*p)->len == 1 && *((*p)->buf) == '\n') {
|
|
|
|
strbuf_addstr(&buf, content_type);
|
|
|
|
strbuf_addbuf(&buf, *p);
|
|
|
|
strbuf_addstr(&buf, pre_open);
|
|
|
|
added_header = 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
encode_html_chars(*p);
|
|
|
|
strbuf_addbuf(&buf, *p);
|
|
|
|
}
|
|
|
|
strbuf_addstr(&buf, pre_close);
|
|
|
|
strbuf_list_free(lines);
|
|
|
|
msg->len = buf.len;
|
|
|
|
msg->data = strbuf_detach(&buf, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
#define CHUNKSIZE 0x1000
|
|
|
|
|
|
|
|
static int read_message(FILE *f, struct msg_data *msg)
|
|
|
|
{
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
memset(msg, 0, sizeof(*msg));
|
|
|
|
|
|
|
|
do {
|
|
|
|
if (strbuf_fread(&buf, CHUNKSIZE, f) <= 0)
|
|
|
|
break;
|
|
|
|
} while (!feof(f));
|
|
|
|
|
|
|
|
msg->len = buf.len;
|
|
|
|
msg->data = strbuf_detach(&buf, NULL);
|
|
|
|
return msg->len;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int count_messages(struct msg_data *msg)
|
|
|
|
{
|
|
|
|
int count = 0;
|
|
|
|
char *p = msg->data;
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
if (!prefixcmp(p, "From ")) {
|
|
|
|
count++;
|
|
|
|
p += 5;
|
|
|
|
}
|
|
|
|
p = strstr(p+5, "\nFrom ");
|
|
|
|
if (!p)
|
|
|
|
break;
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int split_msg(struct msg_data *all_msgs, struct msg_data *msg, int *ofs)
|
|
|
|
{
|
|
|
|
char *p, *data;
|
|
|
|
|
|
|
|
memset(msg, 0, sizeof *msg);
|
|
|
|
if (*ofs >= all_msgs->len)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
data = &all_msgs->data[*ofs];
|
|
|
|
msg->len = all_msgs->len - *ofs;
|
|
|
|
|
|
|
|
if (msg->len < 5 || prefixcmp(data, "From "))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
p = strchr(data, '\n');
|
|
|
|
if (p) {
|
|
|
|
p = &p[1];
|
|
|
|
msg->len -= p-data;
|
|
|
|
*ofs += p-data;
|
|
|
|
data = p;
|
|
|
|
}
|
|
|
|
|
|
|
|
p = strstr(data, "\nFrom ");
|
|
|
|
if (p)
|
|
|
|
msg->len = &p[1] - data;
|
|
|
|
|
|
|
|
msg->data = xmemdupz(data, msg->len);
|
|
|
|
*ofs += msg->len;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct imap_server_conf server = {
|
|
|
|
NULL, /* name */
|
|
|
|
NULL, /* tunnel */
|
|
|
|
NULL, /* host */
|
|
|
|
0, /* port */
|
|
|
|
NULL, /* user */
|
|
|
|
NULL, /* pass */
|
|
|
|
0, /* use_ssl */
|
|
|
|
1, /* ssl_verify */
|
|
|
|
0, /* use_html */
|
|
|
|
};
|
|
|
|
|
|
|
|
static char *imap_folder;
|
|
|
|
|
|
|
|
static int git_imap_config(const char *key, const char *val, void *cb)
|
|
|
|
{
|
|
|
|
char imap_key[] = "imap.";
|
|
|
|
|
|
|
|
if (strncmp(key, imap_key, sizeof imap_key - 1))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (!val)
|
|
|
|
return config_error_nonbool(key);
|
|
|
|
|
|
|
|
key += sizeof imap_key - 1;
|
|
|
|
|
|
|
|
if (!strcmp("folder", key)) {
|
|
|
|
imap_folder = xstrdup(val);
|
|
|
|
} else if (!strcmp("host", key)) {
|
|
|
|
if (!prefixcmp(val, "imap:"))
|
|
|
|
val += 5;
|
|
|
|
else if (!prefixcmp(val, "imaps:")) {
|
|
|
|
val += 6;
|
|
|
|
server.use_ssl = 1;
|
|
|
|
}
|
|
|
|
if (!prefixcmp(val, "//"))
|
|
|
|
val += 2;
|
|
|
|
server.host = xstrdup(val);
|
|
|
|
} else if (!strcmp("user", key))
|
|
|
|
server.user = xstrdup(val);
|
|
|
|
else if (!strcmp("pass", key))
|
|
|
|
server.pass = xstrdup(val);
|
|
|
|
else if (!strcmp("port", key))
|
|
|
|
server.port = git_config_int(key, val);
|
|
|
|
else if (!strcmp("tunnel", key))
|
|
|
|
server.tunnel = xstrdup(val);
|
|
|
|
else if (!strcmp("sslverify", key))
|
|
|
|
server.ssl_verify = git_config_bool(key, val);
|
|
|
|
else if (!strcmp("preformattedHTML", key))
|
|
|
|
server.use_html = git_config_bool(key, val);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int main(int argc, char **argv)
|
|
|
|
{
|
|
|
|
struct msg_data all_msgs, msg;
|
|
|
|
struct store *ctx = NULL;
|
|
|
|
int ofs = 0;
|
|
|
|
int r;
|
|
|
|
int total, n = 0;
|
|
|
|
int nongit_ok;
|
|
|
|
|
|
|
|
git_extract_argv0_path(argv[0]);
|
|
|
|
|
|
|
|
if (argc != 1)
|
|
|
|
usage(imap_send_usage);
|
|
|
|
|
|
|
|
setup_git_directory_gently(&nongit_ok);
|
|
|
|
git_config(git_imap_config, NULL);
|
|
|
|
|
|
|
|
if (!server.port)
|
|
|
|
server.port = server.use_ssl ? 993 : 143;
|
|
|
|
|
|
|
|
if (!imap_folder) {
|
|
|
|
fprintf(stderr, "no imap store specified\n");
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
if (!server.host) {
|
|
|
|
if (!server.tunnel) {
|
|
|
|
fprintf(stderr, "no imap host specified\n");
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
server.host = "tunnel";
|
|
|
|
}
|
|
|
|
|
|
|
|
/* read the messages */
|
|
|
|
if (!read_message(stdin, &all_msgs)) {
|
|
|
|
fprintf(stderr, "nothing to send\n");
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
total = count_messages(&all_msgs);
|
|
|
|
if (!total) {
|
|
|
|
fprintf(stderr, "no messages to send\n");
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* write it to the imap server */
|
|
|
|
ctx = imap_open_store(&server);
|
|
|
|
if (!ctx) {
|
|
|
|
fprintf(stderr, "failed to open store\n");
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
fprintf(stderr, "sending %d message%s\n", total, (total != 1) ? "s" : "");
|
|
|
|
ctx->name = imap_folder;
|
|
|
|
while (1) {
|
|
|
|
unsigned percent = n * 100 / total;
|
|
|
|
fprintf(stderr, "%4u%% (%d/%d) done\r", percent, n, total);
|
|
|
|
if (!split_msg(&all_msgs, &msg, &ofs))
|
|
|
|
break;
|
|
|
|
if (server.use_html)
|
|
|
|
wrap_in_html(&msg);
|
imap-send: remove useless uid code
The imap-send code is based on code from isync, a program
for syncing imap mailboxes. Because of this, it has
inherited some code that makes sense for isync, but not for
imap-send.
In particular, when storing a message, it does one of:
- if the server supports it, note the server-assigned
unique identifier (UID) given to each message
- otherwise, assigned a random UID and store it in the
message header as X-TUID
Presumably this is used in isync to be able to synchronize
mailstores multiple times without duplication. But for
imap-send, the values are useless; we never do anything
with them and simply forget them at the end of the program.
This patch removes the useless code. Not only is it nice for
maintainability to get rid of dead code, but the removed
code relied on the existence of /dev/urandom, which made it
a portability problem for non-Unix platforms.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
15 years ago
|
|
|
r = imap_store_msg(ctx, &msg);
|
|
|
|
if (r != DRV_OK)
|
|
|
|
break;
|
|
|
|
n++;
|
|
|
|
}
|
|
|
|
fprintf(stderr, "\n");
|
|
|
|
|
|
|
|
imap_close_store(ctx);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|