Browse Source

imap-send: properly error out if imap.host is not set in config

If no imap host is specified in the git config, git imap-send used
to try to lookup a null pointer through gethostbyname(), causing a
segfault.  Since setting the imap.host variable is mandatory,
imap-send now properly fails with an explanatory error message.

The problem has been reported by picca through
 http://bugs.debian.org/472632

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Gerrit Pape 17 years ago committed by Junio C Hamano
parent
commit
5b67b8e2d4
  1. 4
      imap-send.c

4
imap-send.c

@ -1302,6 +1302,10 @@ main(int argc, char **argv) @@ -1302,6 +1302,10 @@ main(int argc, char **argv)
fprintf( stderr, "no imap store specified\n" );
return 1;
}
if (!server.host) {
fprintf( stderr, "no imap host specified\n" );
return 1;
}

/* read the messages */
if (!read_message( stdin, &all_msgs )) {

Loading…
Cancel
Save