In the dts parser grammar, a nodedef is defined by
'{' proplist subnodes '}' ';'
with both proplist and subnodes that can be empty lists.
Having multiple possible empty list can lead to Bison warnings such as
warning: 4 shift/reduce conflicts [-Wconflicts-sr]
warning: 1 reduce/reduce conflict [-Wconflicts-rr]
This will happen as soon as a new list (which also could be empty) is
added in the nodedef definition.
The simpler way to remove those warning and thus have a robust parsing
is to avoid multiple empty lists.
Update the proplist definition and nodedef definition to avoid those
multiple empty lists. Instead of allowing a proplist to be an empty
list, force the list to be a non empty one and update the nodedef to
handle explicitly the absence of the proplist to support the case where
no properties are available, i.e. the case of a node composed only of
sub-nodes.
This doesn't change the functional behavior.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Message-ID: <20260826094950.1088288-2-herve.codina@bootlin.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|
||
|---|---|---|
| .github/workflows | ||
| Documentation | ||
| libfdt | ||
| pylibfdt | ||
| scripts | ||
| tests | ||
| .clang-format | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| AGENTS.md | ||
| BSD-2-Clause | ||
| CLAUDE.md | ||
| CONTRIBUTING.md | ||
| GPL | ||
| Makefile | ||
| Makefile.convert-dtsv0 | ||
| Makefile.dtc | ||
| Makefile.utils | ||
| README.license | ||
| README.md | ||
| TODO | ||
| VERSION.txt | ||
| checks.c | ||
| convert-dtsv0-lexer.l | ||
| data.c | ||
| dtc-lexer.l | ||
| dtc-parser.y | ||
| dtc.c | ||
| dtc.h | ||
| dtdiff | ||
| fdtdump.c | ||
| fdtget.c | ||
| fdtoverlay.c | ||
| fdtput.c | ||
| flattree.c | ||
| fstree.c | ||
| livetree.c | ||
| meson.build | ||
| meson_options.txt | ||
| pyproject.toml | ||
| srcpos.c | ||
| srcpos.h | ||
| treesource.c | ||
| util.c | ||
| util.h | ||
| version_gen.h.in | ||
| yamltree.c | ||
README.md
Device Tree Compiler and libfdt
The source tree contains the Device Tree Compiler (dtc) toolchain for working with device tree source and binary files and also libfdt, a utility library for reading and manipulating the binary format.
dtc and libfdt are maintained by:
Python library
A Python library wrapping libfdt is also available. To build this you
will need to install swig and Python development files. On Debian
distributions:
$ sudo apt-get install swig python3-dev
The library provides an Fdt class which you can use like this:
$ PYTHONPATH=../pylibfdt python3
>>> import libfdt
>>> fdt = libfdt.Fdt(open('test_tree1.dtb', mode='rb').read())
>>> node = fdt.path_offset('/subnode@1')
>>> print(node)
124
>>> prop_offset = fdt.first_property_offset(node)
>>> prop = fdt.get_property_by_offset(prop_offset)
>>> print('%s=%s' % (prop.name, prop.as_str()))
compatible=subnode1
>>> node2 = fdt.path_offset('/')
>>> print(fdt.getprop(node2, 'compatible').as_str())
test_tree1
You will find tests in tests/pylibfdt_tests.py showing how to use each
method. Help is available using the Python help command, e.g.:
$ cd pylibfdt
$ python3 -c "import libfdt; help(libfdt)"
If you add new features, please check code coverage:
$ sudo apt-get install python3-coverage
$ cd tests
# It's just 'coverage' on most other distributions
$ python3-coverage run pylibfdt_tests.py
$ python3-coverage html
# Open 'htmlcov/index.html' in your browser
The library can be installed with pip from a local source tree:
$ pip install . [--user|--prefix=/path/to/install_dir]
Or directly from a remote git repo:
$ pip install git+git://git.kernel.org/pub/scm/utils/dtc/dtc.git@main
The install depends on libfdt shared library being installed on the
host system first. Generally, using --user or --prefix is not
necessary and pip will use the default location for the Python
installation which varies if the user is root or not.
You can also install everything via make if you like, but pip is recommended.
To install both libfdt and pylibfdt you can use:
$ make install [PREFIX=/path/to/install_dir]
To disable building the python library, even if swig and Python are available, use:
$ make NO_PYTHON=1
More work remains to support all of libfdt, including access to numeric values.
Mailing lists
- The devicetree-compiler list is for discussion about dtc and libfdt implementation.
- Core device tree bindings are discussed on the devicetree-spec list.