Browse Source

dtc: Fix signedness comparisons warnings: Wrap (-1)

With -Wsign-compare, compilers warn about a mismatching signedness
in a comparison in dtc's data_copy_file().

Even though maxlen is of an unsigned type, we compare against "-1",
which is passed in from the parser to indicate an unknown size.

Cast the "-1" to an unsigned size to make the comparison match.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Message-Id: <20201012161948.23994-9-andre.przywara@arm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
main
Andre Przywara 4 years ago committed by David Gibson
parent
commit
3bc3a6b9fe
  1. 2
      data.c

2
data.c

@ -84,7 +84,7 @@ struct data data_copy_file(FILE *f, size_t maxlen)
while (!feof(f) && (d.len < maxlen)) { while (!feof(f) && (d.len < maxlen)) {
size_t chunksize, ret; size_t chunksize, ret;


if (maxlen == -1) if (maxlen == (size_t)-1)
chunksize = 4096; chunksize = 4096;
else else
chunksize = maxlen - d.len; chunksize = maxlen - d.len;

Loading…
Cancel
Save