From 3bc3a6b9fe0cba171bef7d1cc2b04a362228dd1c Mon Sep 17 00:00:00 2001 From: Andre Przywara Date: Mon, 12 Oct 2020 17:19:45 +0100 Subject: [PATCH] dtc: Fix signedness comparisons warnings: Wrap (-1) With -Wsign-compare, compilers warn about a mismatching signedness in a comparison in dtc's data_copy_file(). Even though maxlen is of an unsigned type, we compare against "-1", which is passed in from the parser to indicate an unknown size. Cast the "-1" to an unsigned size to make the comparison match. Signed-off-by: Andre Przywara Message-Id: <20201012161948.23994-9-andre.przywara@arm.com> Signed-off-by: David Gibson --- data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data.c b/data.c index fdb0407..1473423 100644 --- a/data.c +++ b/data.c @@ -84,7 +84,7 @@ struct data data_copy_file(FILE *f, size_t maxlen) while (!feof(f) && (d.len < maxlen)) { size_t chunksize, ret; - if (maxlen == -1) + if (maxlen == (size_t)-1) chunksize = 4096; else chunksize = maxlen - d.len;