Browse Source

dtc: Fix NULL pointer use in dtlabel + dtref case

If we have a construct like this:

	label: &handle {
		...
	};

Running dtc on it will cause a segfault, because we use 'target'
when it could be NULL. Move the add_label() call into the if
statement to fix this potentially bad use of a NULL pointer.

Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
main
Stephen Boyd 8 years ago committed by David Gibson
parent
commit
3b9c97093d
  1. 4
      dtc-parser.y
  2. 1
      tests/run_tests.sh
  3. 9
      tests/test_label_ref.dts

4
dtc-parser.y

@ -171,10 +171,10 @@ devicetree: @@ -171,10 +171,10 @@ devicetree:
{
struct node *target = get_node_by_ref($1, $3);

if (target) {
add_label(&target->labels, $2);
if (target)
merge_nodes(target, $4);
else
} else
ERROR(&@3, "Label or path %s not found", $3);
$$ = $1;
}

1
tests/run_tests.sh

@ -511,6 +511,7 @@ dtc_tests () { @@ -511,6 +511,7 @@ dtc_tests () {
run_test dtbs_equal_ordered multilabel.test.dtb multilabel_merge.test.dtb
run_dtc_test -I dts -O dtb -o dtc_tree1_merge_path.test.dtb test_tree1_merge_path.dts
tree1_tests dtc_tree1_merge_path.test.dtb test_tree1.dtb
run_wrap_error_test $DTC -I dts -O dtb -o /dev/null test_label_ref.dts

# Check prop/node delete functionality
run_dtc_test -I dts -O dtb -o dtc_tree1_delete.test.dtb test_tree1_delete.dts

9
tests/test_label_ref.dts

@ -0,0 +1,9 @@ @@ -0,0 +1,9 @@
/dts-v1/;

/ {

};

label: &handle {

};
Loading…
Cancel
Save