You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
33 lines
1.0 KiB
33 lines
1.0 KiB
2 years ago
|
From 0c4e5d70fde006977e798d6cc7d80db2e8af7bb9 Mon Sep 17 00:00:00 2001
|
||
|
From: Petr Lautrbach <plautrba@redhat.com>
|
||
|
Date: Tue, 23 Nov 2021 17:38:51 +0100
|
||
|
Subject: [PATCH] semodule: Don't forget to munmap() data
|
||
|
|
||
|
semanage_module_extract() mmap()'s the module raw data but it leaves on
|
||
|
the caller to munmap() them.
|
||
|
|
||
|
Reported-by: Ondrej Mosnacek <omosnace@redhat.com>
|
||
|
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
|
||
|
Acked-by: James Carter <jwcart2@gmail.com>
|
||
|
---
|
||
|
policycoreutils/semodule/semodule.c | 3 +++
|
||
|
1 file changed, 3 insertions(+)
|
||
|
|
||
|
diff --git a/policycoreutils/semodule/semodule.c b/policycoreutils/semodule/semodule.c
|
||
|
index 57f005ce2c62..94a9d131bb79 100644
|
||
|
--- a/policycoreutils/semodule/semodule.c
|
||
|
+++ b/policycoreutils/semodule/semodule.c
|
||
|
@@ -394,6 +394,9 @@ static char *hash_module_data(const char *module_name, const int prio) {
|
||
|
sha256_buf[i * 2] = 0;
|
||
|
|
||
|
cleanup_extract:
|
||
|
+ if (data_len > 0) {
|
||
|
+ munmap(data, data_len);
|
||
|
+ }
|
||
|
semanage_module_info_destroy(sh, extract_info);
|
||
|
free(extract_info);
|
||
|
semanage_module_key_destroy(sh, modkey);
|
||
|
--
|
||
|
2.33.1
|
||
|
|