You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
34 lines
1.5 KiB
34 lines
1.5 KiB
3 years ago
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
Date: Wed, 16 Feb 2022 00:12:29 -0600
|
||
|
|
Subject: [PATCH] libmultipath: fix printing native nvme multipath topology.
|
||
|
|
|
||
|
|
Since commit 2f05df4 ("libmultipath: use strbuf in print.c"), when
|
||
|
|
multipath prints the topology of native nvme devices, instead of
|
||
|
|
printing the multipath device information, it prints "w [G]:d s". This
|
||
|
|
is because nvme_style() switched from calling snprintf(), which supports
|
||
|
|
format specifiers, to append_strbuf_str(), which doesn't, while still
|
||
|
|
keeping the same string, "%%w [%%G]:%%d %%s". Remove the extra percent
|
||
|
|
signs, since they don't need to be escaped in append_strbuf_str().
|
||
|
|
|
||
|
|
Fixes: 2f05df4 ("libmultipath: use strbuf in print.c")
|
||
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
Reviewed-by: Martin Wilck <mwilck@suse.com>
|
||
|
|
---
|
||
|
|
libmultipath/foreign/nvme.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/libmultipath/foreign/nvme.c b/libmultipath/foreign/nvme.c
|
||
|
|
index d40c0869..23355ca5 100644
|
||
|
|
--- a/libmultipath/foreign/nvme.c
|
||
|
|
+++ b/libmultipath/foreign/nvme.c
|
||
|
|
@@ -335,7 +335,7 @@ static int snprint_nvme_pg(const struct gen_pathgroup *gmp,
|
||
|
|
static int nvme_style(__attribute__((unused)) const struct gen_multipath* gm,
|
||
|
|
struct strbuf *buf, __attribute__((unused)) int verbosity)
|
||
|
|
{
|
||
|
|
- return append_strbuf_str(buf, "%%w [%%G]:%%d %%s");
|
||
|
|
+ return append_strbuf_str(buf, "%w [%G]:%d %s");
|
||
|
|
}
|
||
|
|
|
||
|
|
static const struct gen_multipath_ops nvme_map_ops = {
|