You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
41 lines
1.3 KiB
41 lines
1.3 KiB
7 years ago
|
From 8eb5c1e7b2547ad516aeb97d4407758c27c05a54 Mon Sep 17 00:00:00 2001
|
||
|
From: John Ferlan <jferlan@redhat.com>
|
||
|
Date: Wed, 22 Jan 2014 13:28:06 -0500
|
||
|
Subject: [PATCH 45/60] EAFP: Coverity cleanup
|
||
|
|
||
|
A new version of Coverity found:
|
||
|
|
||
|
get_dev_from_pool(): RESOURCE_LEAK
|
||
|
- Because the code is run within a for() loop Coverity complains
|
||
|
that the returned 'poolid' is not free'd during each pass through
|
||
|
the loop. So even though it may not be fetched again, just free()
|
||
|
and reinitialize 'poolid' after usage
|
||
|
|
||
|
Signed-off-by: John Ferlan <jferlan@redhat.com>
|
||
|
---
|
||
|
src/Virt_ElementAllocatedFromPool.c | 6 +++++-
|
||
|
1 file changed, 5 insertions(+), 1 deletion(-)
|
||
|
|
||
|
diff --git a/src/Virt_ElementAllocatedFromPool.c b/src/Virt_ElementAllocatedFromPool.c
|
||
|
index 03d856a..2c2f2d1 100644
|
||
|
--- a/src/Virt_ElementAllocatedFromPool.c
|
||
|
+++ b/src/Virt_ElementAllocatedFromPool.c
|
||
|
@@ -124,10 +124,14 @@ static CMPIStatus get_dev_from_pool(const CMPIObjectPath *ref,
|
||
|
poolid = pool_member_of(_BROKER, cn, type, dev_id);
|
||
|
if (poolid && STREQ(poolid, _poolid))
|
||
|
inst_list_add(list, inst);
|
||
|
+
|
||
|
+ if (poolid) {
|
||
|
+ free(poolid);
|
||
|
+ poolid = NULL;
|
||
|
+ }
|
||
|
}
|
||
|
|
||
|
out:
|
||
|
- free(poolid);
|
||
|
inst_list_free(&tmp);
|
||
|
|
||
|
return s;
|
||
|
--
|
||
|
2.1.0
|