WHATS_NEW | 1 + lib/metadata/mirror.c | 4 ++++ tools/lvconvert.c | 11 ++++++++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index da10eed..762553f 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.178 - ===================================== + Add deprecate messages for usage of mirrors with mirrorlog. Restore pvmove support for wide-clustered active volumes (2.02.177). Avoid non-exclusive activation of exclusive segment types. Fix trimming sibling PVs when doing a pvmove of raid subLVs. diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 38c3df6..4a0e99f 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1945,6 +1945,10 @@ int add_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, return 1; } + if (log_count > 1) { + log_warn("WARNING: Log type \"mirrored\" is DEPRECATED and will be removed in the future. Use RAID1 LV or disk log instead."); + } + if (!(parallel_areas = build_parallel_areas_from_lv(lv, 0, 0))) return_0; diff --git a/tools/lvconvert.c b/tools/lvconvert.c index fee0a4e..8006699 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -686,7 +686,7 @@ static void _remove_missing_empty_pv(struct volume_group *vg, struct dm_list *re stack; return; } - log_warn("%d missing and now unallocated Physical Volumes removed from VG.", removed); + log_warn("WARNING: %d missing and now unallocated Physical Volumes removed from VG.", removed); } } @@ -828,7 +828,7 @@ static int _lvconvert_mirrors_aux(struct cmd_context *cmd, uint32_t old_log_count = _get_log_count(lv); if ((lp->mirrors == 1) && !lv_is_mirrored(lv)) { - log_warn("Logical volume %s is already not mirrored.", + log_warn("WARNING: Logical volume %s is already not mirrored.", display_lvname(lv)); return 1; } @@ -1100,7 +1100,7 @@ static int _lvconvert_mirrors_repair(struct cmd_context *cmd, log_count = replace_logs ? original_logs : (original_logs - failed_logs); while (replace_mimages || replace_logs) { - log_warn("Trying to up-convert to %d images, %d logs.", lp->mirrors, log_count); + log_warn("WARNING: Trying to up-convert to %d images, %d logs.", lp->mirrors, log_count); if (_lvconvert_mirrors_aux(cmd, lv, lp, NULL, lp->mirrors, log_count, pvh)) break; @@ -1216,6 +1216,11 @@ static int _lvconvert_mirrors(struct cmd_context *cmd, (old_log_count == new_log_count)) return 1; + if ((old_log_count != new_log_count) && + (new_log_count == MIRROR_LOG_MIRRORED)) { + log_warn("WARNING: Log type \"mirrored\" is DEPRECATED and will be removed in the future. Use RAID1 LV or disk log instead."); + } + if (!_lvconvert_mirrors_aux(cmd, lv, lp, NULL, new_mimage_count, new_log_count, lp->pvh)) return_0;