You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
28 lines
819 B
28 lines
819 B
7 years ago
|
commit a705076172b274463563416adffe55f129740267
|
||
|
|
Author: Steve Dickson <steved@redhat.com>
|
||
|
|
Date: Thu Jul 30 17:06:39 2015 -0400
|
||
|
|
|
||
|
|
rpc.gssd: Only clear the retval if it has not been set
|
||
|
|
|
||
|
|
In gssd_search_krb5_keytab() an error code can be
|
||
|
|
cleared by blindly setting retval to zero.
|
||
|
|
|
||
|
|
Reported-by: Jianhong Yin <jiyin@redhat.com>
|
||
|
|
Signed-off-by: Steve Dickson <steved@redhat.com>
|
||
|
|
|
||
|
|
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
|
||
|
|
index f1ebc0d..ecf17a2 100644
|
||
|
|
--- a/utils/gssd/krb5_util.c
|
||
|
|
+++ b/utils/gssd/krb5_util.c
|
||
|
|
@@ -772,7 +772,9 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt,
|
||
|
|
"keytab '%s'\n", k5err, kt_name);
|
||
|
|
}
|
||
|
|
|
||
|
|
- retval = 0;
|
||
|
|
+ /* Only clear the retval if has not been set */
|
||
|
|
+ if (retval < 0)
|
||
|
|
+ retval = 0;
|
||
|
|
out:
|
||
|
|
free(k5err);
|
||
|
|
return retval;
|