You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
40 lines
1.1 KiB
40 lines
1.1 KiB
6 years ago
|
From 397b06ff74f7fd8fc71f5991bdfbfa6ef6da98fd Mon Sep 17 00:00:00 2001
|
||
|
From: Peter Jones <pjones@redhat.com>
|
||
|
Date: Thu, 2 Feb 2017 15:25:48 -0500
|
||
|
Subject: [PATCH 05/10] Fix a sign error in the debughook example app
|
||
|
|
||
|
On ISO C90 on i386 4294967294 is a signed integer, and so x can't be
|
||
|
greater (or equal) to that. Make it an unsigned and choose a better type
|
||
|
for the variable.
|
||
|
|
||
|
Signed-off-by: Peter Jones <pjones@redhat.com>
|
||
|
---
|
||
|
apps/debughook.c | 4 ++--
|
||
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
||
|
diff --git a/apps/debughook.c b/apps/debughook.c
|
||
|
index fb6cdad..e1d1c50 100644
|
||
|
--- a/apps/debughook.c
|
||
|
+++ b/apps/debughook.c
|
||
|
@@ -45,7 +45,7 @@ DebugHook(void)
|
||
|
UINT8 *data = NULL;
|
||
|
UINTN dataSize = 0;
|
||
|
EFI_STATUS efi_status;
|
||
|
- register volatile UINTN x = 0;
|
||
|
+ register volatile unsigned long long x = 0;
|
||
|
extern char _text, _data;
|
||
|
|
||
|
if (x)
|
||
|
@@ -66,7 +66,7 @@ DebugHook(void)
|
||
|
while (x++) {
|
||
|
/* Make this so it can't /totally/ DoS us. */
|
||
|
#if defined(__x86_64__) || defined(__i386__) || defined(__i686__)
|
||
|
- if (x > 4294967294)
|
||
|
+ if (x > 4294967294ULL)
|
||
|
break;
|
||
|
__asm__ __volatile__("pause");
|
||
|
#elif defined(__aarch64__)
|
||
|
--
|
||
|
2.9.3
|
||
|
|