You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
78 lines
2.5 KiB
78 lines
2.5 KiB
4 years ago
|
From 0bf795555728e54db2593a73f90d7820cf3ef4c6 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Phil Sutter <psutter@redhat.com>
|
||
|
|
Date: Fri, 15 Mar 2019 17:50:34 +0100
|
||
|
|
Subject: [PATCH] libxt_ipvs: Avoid potential buffer overrun
|
||
|
|
|
||
|
|
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1525980
|
||
|
|
Upstream Status: iptables commit 749d3c2ecd6a9
|
||
|
|
|
||
|
|
commit 749d3c2ecd6a9dc21f5a442c44495cb705621dff
|
||
|
|
Author: Phil Sutter <phil@nwl.cc>
|
||
|
|
Date: Wed Sep 19 15:16:51 2018 +0200
|
||
|
|
|
||
|
|
libxt_ipvs: Avoid potential buffer overrun
|
||
|
|
|
||
|
|
Just like with libxt_conntrack, get rid of the temporary buffer. The
|
||
|
|
comment even states that it was copied from there, so just make them
|
||
|
|
identical again.
|
||
|
|
|
||
|
|
Signed-off-by: Phil Sutter <phil@nwl.cc>
|
||
|
|
Signed-off-by: Florian Westphal <fw@strlen.de>
|
||
|
|
|
||
|
|
Signed-off-by: Phil Sutter <psutter@redhat.com>
|
||
|
|
---
|
||
|
|
extensions/libxt_ipvs.c | 22 ++++++++++++----------
|
||
|
|
1 file changed, 12 insertions(+), 10 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/extensions/libxt_ipvs.c b/extensions/libxt_ipvs.c
|
||
|
|
index 46727660a027a..a6c57a030d2c6 100644
|
||
|
|
--- a/extensions/libxt_ipvs.c
|
||
|
|
+++ b/extensions/libxt_ipvs.c
|
||
|
|
@@ -126,19 +126,19 @@ static void ipvs_mt_dump_addr(const union nf_inet_addr *addr,
|
||
|
|
const union nf_inet_addr *mask,
|
||
|
|
unsigned int family, bool numeric)
|
||
|
|
{
|
||
|
|
- char buf[BUFSIZ];
|
||
|
|
-
|
||
|
|
if (family == NFPROTO_IPV4) {
|
||
|
|
if (!numeric && addr->ip == 0) {
|
||
|
|
printf(" anywhere");
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
if (numeric)
|
||
|
|
- strcpy(buf, xtables_ipaddr_to_numeric(&addr->in));
|
||
|
|
+ printf(" %s%s",
|
||
|
|
+ xtables_ipaddr_to_numeric(&addr->in),
|
||
|
|
+ xtables_ipmask_to_numeric(&mask->in));
|
||
|
|
else
|
||
|
|
- strcpy(buf, xtables_ipaddr_to_anyname(&addr->in));
|
||
|
|
- strcat(buf, xtables_ipmask_to_numeric(&mask->in));
|
||
|
|
- printf(" %s", buf);
|
||
|
|
+ printf(" %s%s",
|
||
|
|
+ xtables_ipaddr_to_anyname(&addr->in),
|
||
|
|
+ xtables_ipmask_to_numeric(&mask->in));
|
||
|
|
} else if (family == NFPROTO_IPV6) {
|
||
|
|
if (!numeric && addr->ip6[0] == 0 && addr->ip6[1] == 0 &&
|
||
|
|
addr->ip6[2] == 0 && addr->ip6[3] == 0) {
|
||
|
|
@@ -146,11 +146,13 @@ static void ipvs_mt_dump_addr(const union nf_inet_addr *addr,
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
if (numeric)
|
||
|
|
- strcpy(buf, xtables_ip6addr_to_numeric(&addr->in6));
|
||
|
|
+ printf(" %s%s",
|
||
|
|
+ xtables_ip6addr_to_numeric(&addr->in6),
|
||
|
|
+ xtables_ip6mask_to_numeric(&mask->in6));
|
||
|
|
else
|
||
|
|
- strcpy(buf, xtables_ip6addr_to_anyname(&addr->in6));
|
||
|
|
- strcat(buf, xtables_ip6mask_to_numeric(&mask->in6));
|
||
|
|
- printf(" %s", buf);
|
||
|
|
+ printf(" %s%s",
|
||
|
|
+ xtables_ip6addr_to_anyname(&addr->in6),
|
||
|
|
+ xtables_ip6mask_to_numeric(&mask->in6));
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
--
|
||
|
|
2.21.0
|
||
|
|
|