You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
40 lines
1.2 KiB
40 lines
1.2 KiB
4 years ago
|
From 0833f9c3dbaaee202b92ea956f9e2decc7b9593a Mon Sep 17 00:00:00 2001
|
||
|
|
From: Gioh Kim <gi-oh.kim@profitbricks.com>
|
||
|
|
Date: Tue, 6 Nov 2018 15:27:42 +0100
|
||
|
|
Subject: [RHEL7.7 PATCH 01/21] Assemble: keep MD_DISK_FAILFAST and
|
||
|
|
MD_DISK_WRITEMOSTLY flag
|
||
|
|
|
||
|
|
Before updating superblock of slave disks, desired_state value
|
||
|
|
is set for the target state of the slave disks. But it forgets
|
||
|
|
to check MD_DISK_FAILFAST and MD_DISK_WRITEMOSTLY flags. Then
|
||
|
|
start_arrays() calls ADD_NEW_DISK ioctl-call and pass the state
|
||
|
|
without MD_DISK_FAILFAST and MD_DISK_WRITEMOSTLY.
|
||
|
|
|
||
|
|
Currenlty it does not generate any problem because kernel does not
|
||
|
|
care MD_DISK_FAILFAST or MD_DISK_WRITEMOSTLY flags.
|
||
|
|
|
||
|
|
Reviewed-by: NeilBrown <neilb@suse.com>
|
||
|
|
Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
|
||
|
|
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
|
||
|
|
---
|
||
|
|
Assemble.c | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/Assemble.c b/Assemble.c
|
||
|
|
index a79466c..f39c9e1 100644
|
||
|
|
--- a/Assemble.c
|
||
|
|
+++ b/Assemble.c
|
||
|
|
@@ -1704,6 +1704,9 @@ try_again:
|
||
|
|
else
|
||
|
|
desired_state = (1<<MD_DISK_ACTIVE) | (1<<MD_DISK_SYNC);
|
||
|
|
|
||
|
|
+ desired_state |= devices[j].i.disk.state & ((1<<MD_DISK_FAILFAST) |
|
||
|
|
+ (1<<MD_DISK_WRITEMOSTLY));
|
||
|
|
+
|
||
|
|
if (!devices[j].uptodate)
|
||
|
|
continue;
|
||
|
|
|
||
|
|
--
|
||
|
|
2.7.5
|
||
|
|
|