You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
48 lines
1.2 KiB
48 lines
1.2 KiB
7 years ago
|
From 8e0cdc0c0cdb3be1ed0e3ed0abd382c924b56a9e Mon Sep 17 00:00:00 2001
|
||
|
|
From: Hector Marco-Gisbert <hecmargi@upv.es>
|
||
|
|
Date: Fri, 13 Nov 2015 16:21:09 +0100
|
||
|
|
Subject: [PATCH 185/237] Fix security issue when reading username and password
|
||
|
|
|
||
|
|
This patch fixes two integer underflows at:
|
||
|
|
* grub-core/lib/crypto.c
|
||
|
|
* grub-core/normal/auth.c
|
||
|
|
|
||
|
|
Resolves: CVE-2015-8370
|
||
|
|
|
||
|
|
Signed-off-by: Hector Marco-Gisbert <hecmargi@upv.es>
|
||
|
|
Signed-off-by: Ismael Ripoll-Ripoll <iripoll@disca.upv.es>
|
||
|
|
---
|
||
|
|
grub-core/lib/crypto.c | 2 +-
|
||
|
|
grub-core/normal/auth.c | 2 +-
|
||
|
|
2 files changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/grub-core/lib/crypto.c b/grub-core/lib/crypto.c
|
||
|
|
index 8e8426c..a23519c 100644
|
||
|
|
--- a/grub-core/lib/crypto.c
|
||
|
|
+++ b/grub-core/lib/crypto.c
|
||
|
|
@@ -456,7 +456,7 @@ grub_password_get (char buf[], unsigned buf_size)
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
|
||
|
|
- if (key == '\b')
|
||
|
|
+ if (key == '\b' && cur_len)
|
||
|
|
{
|
||
|
|
cur_len--;
|
||
|
|
continue;
|
||
|
|
diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
|
||
|
|
index c6bd96e..5782ec5 100644
|
||
|
|
--- a/grub-core/normal/auth.c
|
||
|
|
+++ b/grub-core/normal/auth.c
|
||
|
|
@@ -172,7 +172,7 @@ grub_username_get (char buf[], unsigned buf_size)
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
|
||
|
|
- if (key == '\b')
|
||
|
|
+ if (key == '\b' && cur_len)
|
||
|
|
{
|
||
|
|
cur_len--;
|
||
|
|
grub_printf ("\b");
|
||
|
|
--
|
||
|
|
2.9.3
|
||
|
|
|