Eric Sunshine fd4094c3ca chainlint.pl: complain about loops lacking explicit failure handling ... Shell `for` and `while` loops do not terminate automatically just because a command fails within the loop body. Instead, the loop continues to iterate and eventually returns the exit status of the final command of the final iteration, which may not be the command which failed, thus it is possible for failures to go undetected. Consequently, it is important for test authors to explicitly handle failure within the loop body by terminating the loop manually upon failure. This can be done by returning a non-zero exit code from within the loop body (i.e. `|| return 1`) or exiting (i.e. `|| exit 1`) if the loop is within a subshell, or by manually checking `$?` and taking some appropriate action. Therefore, add logic to detect and complain about loops which lack explicit `return` or `exit`, or `$?` check. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2022-09-01 10:07:41 -07:00
..
arithmetic-expansion.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
arithmetic-expansion.test	…
bash-array.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
bash-array.test	…
blank-line.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
blank-line.test	t/chainlint/*.test: generalize self-test commentary	2021-12-13 14:15:28 -08:00
block-comment.expect	chainlint.sed: swallow comments consistently	2021-12-13 14:15:29 -08:00
block-comment.test	chainlint.sed: swallow comments consistently	2021-12-13 14:15:29 -08:00
block.expect	t/Makefile: apply chainlint.pl to existing self-tests	2022-09-01 10:07:40 -07:00
block.test	t/chainlint/*.test: generalize self-test commentary	2021-12-13 14:15:28 -08:00
broken-chain.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
broken-chain.test	…
case-comment.expect	chainlint.sed: swallow comments consistently	2021-12-13 14:15:29 -08:00
case-comment.test	chainlint.sed: swallow comments consistently	2021-12-13 14:15:29 -08:00
case.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
case.test	…
chain-break-background.expect	chainlint.pl: don't require `&` background command to end with `&&`	2022-09-01 10:07:40 -07:00
chain-break-background.test	chainlint.pl: don't require `&` background command to end with `&&`	2022-09-01 10:07:40 -07:00
chain-break-continue.expect	chainlint.pl: don't require `return|exit|continue` to end with `&&`	2022-09-01 10:07:40 -07:00
chain-break-continue.test	chainlint.pl: don't require `return|exit|continue` to end with `&&`	2022-09-01 10:07:40 -07:00
chain-break-false.expect	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
chain-break-false.test	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
chain-break-return-exit.expect	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
chain-break-return-exit.test	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
chain-break-status.expect	chainlint.pl: don't flag broken &&-chain if `$?` handled explicitly	2022-09-01 10:07:41 -07:00
chain-break-status.test	chainlint.pl: don't flag broken &&-chain if `$?` handled explicitly	2022-09-01 10:07:41 -07:00
close-nested-and-parent-together.expect	chainlint.sed: stop splitting "(..." into separate lines "(" and "..."	2021-12-13 14:15:29 -08:00
close-nested-and-parent-together.test	…
close-subshell.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
close-subshell.test	…
command-substitution.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
command-substitution.test	…
comment.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
comment.test	…
complex-if-in-cuddled-loop.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
complex-if-in-cuddled-loop.test	…
cuddled-if-then-else.expect	chainlint.sed: stop splitting "(..." into separate lines "(" and "..."	2021-12-13 14:15:29 -08:00
cuddled-if-then-else.test	…
cuddled-loop.expect	chainlint.sed: stop splitting "(..." into separate lines "(" and "..."	2021-12-13 14:15:29 -08:00
cuddled-loop.test	…
cuddled.expect	chainlint.sed: stop splitting "(..." into separate lines "(" and "..."	2021-12-13 14:15:29 -08:00
cuddled.test	t/chainlint/*.test: generalize self-test commentary	2021-12-13 14:15:28 -08:00
exit-loop.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
exit-loop.test	…
exit-subshell.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
exit-subshell.test	…
for-loop.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
for-loop.test	…
here-doc-close-subshell.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
here-doc-close-subshell.test	…
here-doc-multi-line-command-subst.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
here-doc-multi-line-command-subst.test	…
here-doc-multi-line-string.expect	t/Makefile: apply chainlint.pl to existing self-tests	2022-09-01 10:07:40 -07:00
here-doc-multi-line-string.test	…
here-doc.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
here-doc.test	…
if-in-loop.expect	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
if-in-loop.test	chainlint.pl: don't flag broken &&-chain if failure indicated explicitly	2022-09-01 10:07:41 -07:00
if-then-else.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
if-then-else.test	…
incomplete-line.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
incomplete-line.test	…
inline-comment.expect	chainlint.sed: stop splitting "(..." into separate lines "(" and "..."	2021-12-13 14:15:29 -08:00
inline-comment.test	…
loop-detect-failure.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
loop-detect-failure.test	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
loop-detect-status.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
loop-detect-status.test	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
loop-in-if.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
loop-in-if.test	…
multi-line-nested-command-substitution.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
multi-line-nested-command-substitution.test	…
multi-line-string.expect	t/Makefile: apply chainlint.pl to existing self-tests	2022-09-01 10:07:40 -07:00
multi-line-string.test	…
negated-one-liner.expect	chainlint.sed: drop unnecessary distinction between ?!AMP?! and ?!SEMI?!	2021-12-13 14:15:29 -08:00
negated-one-liner.test	…
nested-cuddled-subshell.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
nested-cuddled-subshell.test	…
nested-here-doc.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
nested-here-doc.test	…
nested-loop-detect-failure.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
nested-loop-detect-failure.test	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
nested-subshell-comment.expect	chainlint.sed: swallow comments consistently	2021-12-13 14:15:29 -08:00
nested-subshell-comment.test	…
nested-subshell.expect	t/Makefile: apply chainlint.pl to existing self-tests	2022-09-01 10:07:40 -07:00
nested-subshell.test	t/chainlint/*.test: generalize self-test commentary	2021-12-13 14:15:28 -08:00
not-heredoc.expect	chainlint.sed: don't mistake `<< word` in string as here-doc operator	2021-12-13 14:15:29 -08:00
not-heredoc.test	chainlint.sed: don't mistake `<< word` in string as here-doc operator	2021-12-13 14:15:29 -08:00
one-liner.expect	chainlint.sed: drop unnecessary distinction between ?!AMP?! and ?!SEMI?!	2021-12-13 14:15:29 -08:00
one-liner.test	t/chainlint/one-liner: avoid overly intimate chainlint.sed knowledge	2021-12-13 14:15:28 -08:00
p4-filespec.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
p4-filespec.test	…
pipe.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
pipe.test	…
return-loop.expect	chainlint.pl: don't require `return|exit|continue` to end with `&&`	2022-09-01 10:07:40 -07:00
return-loop.test	chainlint.pl: don't require `return|exit|continue` to end with `&&`	2022-09-01 10:07:40 -07:00
semicolon.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
semicolon.test	t/chainlint/*.test: generalize self-test commentary	2021-12-13 14:15:28 -08:00
subshell-here-doc.expect	chainlint.sed: stop throwing away here-doc tags	2021-12-13 14:15:29 -08:00
subshell-here-doc.test	…
subshell-one-liner.expect	chainlint.sed: drop subshell-closing ">" annotation	2021-12-13 14:15:29 -08:00
subshell-one-liner.test	…
t7900-subtree.expect	t/Makefile: apply chainlint.pl to existing self-tests	2022-09-01 10:07:40 -07:00
t7900-subtree.test	…
while-loop.expect	chainlint.pl: complain about loops lacking explicit failure handling	2022-09-01 10:07:41 -07:00
while-loop.test	…