git/compat at dbc1b1f71052c084a84b5c395e1cb4b5ae526fcb - git

History

Ramsay Jones 5322ef2006 Fix some printf format warnings commit `51ea551` ("make sure byte swapping is optimal for git" 2009-08-18) introduced a "sane definition for ntohl()/htonl()" for use on some GNU C platforms. Unfortunately, for some of these platforms, this results in the introduction of a problem which is essentially the reverse of a problem that commit `6e1c234` ("Fix some warnings (on cygwin) to allow -Werror" 2008-07-3) was intended to fix. In particular, on platforms where the uint32_t type is defined to be unsigned long, the return type of the new ntohl()/htonl() is causing gcc to issue printf format warnings, such as: warning: long unsigned int format, unsigned int arg (arg 3) (nine such warnings, covering six different files). The earlier commit (`6e1c234`) needed to suppress these same warnings, except that the types were in the opposite direction; namely the format specifier ("%u") was 'unsigned int' and the argument type (ie the return type of ntohl()) was 'long unsigned int' (aka uint32_t). In order to suppress these warnings, the earlier commit used the (C99) PRIu32 format specifier, since the definition of this macro is suitable for use with the uint32_t type on that platform. This worked because the return type of the (original) platform ntohl()/htonl() functions was uint32_t. In order to suppress these warnings, we change the return type of the new byte swapping functions in the compat/bswap.h header file from 'unsigned int' to uint32_t. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Acked-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Jeff King <peff@peff.net>		16 years ago
..
fnmatch	Fix more typos/spelling in comments	16 years ago
nedmalloc	Fix typo in nedmalloc warning fix	16 years ago
regex	Change regerror() declaration from K&R style to ANSI C (C89)	16 years ago
vcbuild	Add scripts to generate projects for other buildsystems (MSVC vcproj, QMake)	16 years ago
basename.c	compat: add a basename() compatibility function	16 years ago
bswap.h	Fix some printf format warnings	16 years ago
cygwin.c	Fix more typos/spelling in comments	16 years ago
cygwin.h	cygwin: Use native Win32 API for stat	17 years ago
fopen.c	compat/fopen.c: avoid clobbering the system defined fopen macro	17 years ago
hstrerror.c	Add a local implementation of hstrerror for the system which do not have it	18 years ago
inet_ntop.c	Remove a couple of duplicated include	17 years ago
inet_pton.c	Remove a couple of duplicated include	17 years ago
memmem.c	optimize compat/ memmem()	16 years ago
mingw.c	Make usage of windows.h lean and mean	16 years ago
mingw.h	Make usage of windows.h lean and mean	16 years ago
mkdtemp.c	Define compat version of mkdtemp for systems lacking it	18 years ago
mkstemps.c	compat: add a mkstemps() compatibility function	16 years ago
mmap.c	…
msvc.c	Add platform files for porting to MSVC	16 years ago
msvc.h	Define strncasecmp and ftruncate for MSVC	16 years ago
pread.c	…
qsort.c	compat: Add simplified merge sort implementation from glibc	17 years ago
setenv.c	…
snprintf.c	Test for WIN32 instead of __MINGW32_	16 years ago
strcasestr.c	…
strlcpy.c	…
strtoumax.c	…
unsetenv.c	…
win32.h	Make usage of windows.h lean and mean	16 years ago
win32mmap.c	MinGW: implement mmap	16 years ago
winansi.c	Make usage of windows.h lean and mean	16 years ago