git/poll at d4c813689b2b320f8907a615fcf1f1d27ae44f37 - git

Tree: d4c813689b

Steve Hoelzer e8dfcace31 poll: use GetTickCount64() to avoid wrap-around issues The value of timeout starts as an int value, and for this reason it cannot overflow unsigned long long aka ULONGLONG. The unsigned version of this initial value is available in orig_timeout. The difference (orig_timeout - elapsed) cannot wrap around because it is protected by a conditional (as can be seen in the patch text). Hence, the ULONGLONG difference can only have values that are smaller than the initial timeout value and truncation to int cannot overflow. Signed-off-by: Steve Hoelzer <shoelzer@gmail.com> [j6t: improved both implementation and log message] Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>	6 years ago
..
poll.c	poll: use GetTickCount64() to avoid wrap-around issues	6 years ago
poll.h	compat/poll: prepare for targeting Windows Vista	6 years ago

Steve Hoelzer e8dfcace31 poll: use GetTickCount64() to avoid wrap-around issues

The value of timeout starts as an int value, and for this reason it
cannot overflow unsigned long long aka ULONGLONG. The unsigned version
of this initial value is available in orig_timeout. The difference
(orig_timeout - elapsed) cannot wrap around because it is protected by
a conditional (as can be seen in the patch text). Hence, the ULONGLONG
difference can only have values that are smaller than the initial
timeout value and truncation to int cannot overflow.

Signed-off-by: Steve Hoelzer <shoelzer@gmail.com>
[j6t: improved both implementation and log message]
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

6 years ago

poll.c

poll: use GetTickCount64() to avoid wrap-around issues

6 years ago

poll.h

compat/poll: prepare for targeting Windows Vista

6 years ago