kernel/git - git - PowerEL Git System

Andy Whitcroft cf606e3ddd git name-rev writes beyond the end of malloc() with large generations When using git name-rev on my kernel tree I triggered a malloc() corruption warning from glibc. apw@pinky$ git log --pretty=one $N/base.. \| git name-rev --stdin * glibc detected * malloc(): memory corruption: 0x0bff8950 *** Aborted This comes from name_rev() which is building the name of the revision in a malloc'd string, which it sprintf's into: char new_name = xmalloc(len + 8); [...] sprintf(new_name, "%.s~%d^%d", len, tip_name, generation, parent_number); This allocation is only sufficient if the generation number is less than 5 digits, in my case generation was 13432. In reality parent_number can be up to 16 so that also can require two digits, reducing us to 3 digits before we are at risk of blowing this allocation. This patch introduces a decimal_length() which approximates the number of digits a type may hold, it produces the following: Type Longest Value Len Est ---- ------------- --- --- unsigned char 256 3 4 unsigned short 65536 5 6 unsigned long 4294967296 10 11 unsigned long long 18446744073709551616 20 21 char -128 4 4 short -32768 6 6 long -2147483648 11 11 long long -9223372036854775808 20 21 This is then used to size the new_name. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Junio C Hamano <junkio@cox.net>		18 years ago
Documentation	Documentation/branch: fix small typo in -D example	18 years ago
arm	Fix an unmatched comment end in arm/sha1_arm.S	18 years ago
compat	…
contrib	Properly handle '0' filenames in import-tars	18 years ago
git-gui	Merge branch 'maint' of git://repo.or.cz/git-gui into maint	18 years ago
gitweb	gitweb: Add a few comments about %feature hash	18 years ago
mozilla-sha1	…
perl	…
ppc	…
t	git-svn: don't attempt to minimize URLs by default	18 years ago
templates	…
xdiff	…
.gitignore	…
.mailmap	.mailmap: add some aliases	18 years ago
COPYING	…
GIT-VERSION-GEN	GIT v1.5.1.4	18 years ago
INSTALL	…
Makefile	…
README	…
RelNotes	Prepare for 1.5.1.5 Release Notes	18 years ago
alloc.c	…
archive-tar.c	…
archive-zip.c	…
archive.h	…
base85.c	…
blob.c	…
blob.h	…
builtin-add.c	…
builtin-annotate.c	…
builtin-apply.c	…
builtin-archive.c	…
builtin-blame.c	blame: -C -C -C	18 years ago
builtin-branch.c	…
builtin-bundle.c	…
builtin-cat-file.c	…
builtin-check-ref-format.c	…
builtin-checkout-index.c	…
builtin-commit-tree.c	…
builtin-config.c	…
builtin-count-objects.c	…
builtin-describe.c	…
builtin-diff-files.c	…
builtin-diff-index.c	…
builtin-diff-tree.c	…
builtin-diff.c	…
builtin-fetch--tool.c	…
builtin-fmt-merge-msg.c	…
builtin-for-each-ref.c	…
builtin-fsck.c	…
builtin-gc.c	…
builtin-grep.c	…
builtin-init-db.c	…
builtin-log.c	builtin-log.c: Fix typo in comment	18 years ago
builtin-ls-files.c	…
builtin-ls-tree.c	…
builtin-mailinfo.c	…
builtin-mailsplit.c	…
builtin-merge-base.c	…
builtin-merge-file.c	…
builtin-mv.c	…
builtin-name-rev.c	git name-rev writes beyond the end of malloc() with large generations	18 years ago
builtin-pack-objects.c	…
builtin-pack-refs.c	…
builtin-prune-packed.c	…
builtin-prune.c	…
builtin-push.c	…
builtin-read-tree.c	…
builtin-reflog.c	…
builtin-rerere.c	…
builtin-rev-list.c	…
builtin-rev-parse.c	…
builtin-revert.c	…
builtin-rm.c	…
builtin-runstatus.c	…
builtin-shortlog.c	…
builtin-show-branch.c	…
builtin-show-ref.c	…
builtin-stripspace.c	…
builtin-symbolic-ref.c	…
builtin-tar-tree.c	…
builtin-unpack-objects.c	…
builtin-update-index.c	…
builtin-update-ref.c	…
builtin-upload-archive.c	…
builtin-verify-pack.c	…
builtin-write-tree.c	…
builtin.h	…
cache-tree.c	…
cache-tree.h	…
cache.h	…
check-builtins.sh	…
check-racy.c	…
color.c	…
color.h	…
combine-diff.c	…
commit.c	Small correction in reading of commit headers	18 years ago
commit.h	…
config.c	git-config: do not forget seeing "a.b.var" means we are out of "a.var" section.	18 years ago
config.mak.in	…
configure.ac	…
connect.c	…
convert-objects.c	…
convert.c	…
copy.c	…
csum-file.c	…
csum-file.h	…
ctype.c	…
daemon.c	…
date.c	…
delta.h	…
diff-delta.c	…
diff-lib.c	…
diff.c	…
diff.h	…
diffcore-break.c	…
diffcore-delta.c	…
diffcore-order.c	…
diffcore-pickaxe.c	…
diffcore-rename.c	…
diffcore.h	…
dir.c	…
dir.h	…
dump-cache-tree.c	…
entry.c	…
environment.c	…
exec_cmd.c	…
exec_cmd.h	…
fast-import.c	…
fetch-pack.c	…
fetch.c	…
fetch.h	…
generate-cmdlist.sh	…
git-add--interactive.perl	…
git-am.sh	…
git-applymbox.sh	…
git-applypatch.sh	…
git-archimport.perl	…
git-bisect.sh	…
git-checkout.sh	checkout: allow detaching to HEAD even when switching to the tip of a branch	18 years ago
git-clean.sh	…
git-clone.sh	Fix git-clone buglet for remote case.	18 years ago
git-commit.sh	…
git-compat-util.h	git name-rev writes beyond the end of malloc() with large generations	18 years ago
git-cvsexportcommit.perl	…
git-cvsimport.perl	…
git-cvsserver.perl	…
git-fetch.sh	…
git-instaweb.sh	…
git-lost-found.sh	…
git-ls-remote.sh	…
git-merge-octopus.sh	…
git-merge-one-file.sh	…
git-merge-ours.sh	…
git-merge-resolve.sh	…
git-merge-stupid.sh	…
git-merge.sh	…
git-mergetool.sh	…
git-p4import.py	…
git-parse-remote.sh	Allow fetching references from any namespace	18 years ago
git-pull.sh	…
git-quiltimport.sh	…
git-rebase.sh	…
git-relink.perl	…
git-remote.perl	…
git-repack.sh	…
git-request-pull.sh	…
git-reset.sh	…
git-send-email.perl	…
git-sh-setup.sh	…
git-svn.perl	git-svn: don't attempt to minimize URLs by default	18 years ago
git-svnimport.perl	…
git-tag.sh	…
git-verify-tag.sh	…
git.c	…
git.spec.in	RPM spec: include files in technical/ to package.	18 years ago
gitk	…
grep.c	…
grep.h	…
hash-object.c	…
help.c	…
http-fetch.c	…
http-push.c	…
http.c	…
http.h	…
ident.c	…
imap-send.c	…
index-pack.c	…
interpolate.c	…
interpolate.h	…
list-objects.c	…
list-objects.h	…
local-fetch.c	…
lockfile.c	…
log-tree.c	Fix --boundary output	18 years ago
log-tree.h	…
merge-file.c	…
merge-index.c	…
merge-recursive.c	…
merge-tree.c	…
mktag.c	…
mktree.c	…
object-refs.c	…
object.c	…
object.h	…
pack-check.c	…
pack-redundant.c	…
pack.h	…
pager.c	…
patch-delta.c	…
patch-id.c	…
path-list.c	…
path-list.h	…
path.c	…
peek-remote.c	…
pkt-line.c	…
pkt-line.h	…
quote.c	…
quote.h	…
reachable.c	…
reachable.h	…
read-cache.c	…
receive-pack.c	…
reflog-walk.c	…
reflog-walk.h	…
refs.c	…
refs.h	…
revision.c	…
revision.h	…
rsh.c	…
rsh.h	…
run-command.c	…
run-command.h	…
send-pack.c	…
server-info.c	…
setup.c	…
sha1_file.c	…
sha1_name.c	…
shallow.c	…
shell.c	…
show-index.c	…
sideband.c	…
sideband.h	…
ssh-fetch.c	…
ssh-pull.c	…
ssh-push.c	…
ssh-upload.c	…
strbuf.c	…
strbuf.h	…
tag.c	…
tag.h	…
tar.h	…
test-chmtime.c	…
test-date.c	…
test-delta.c	…
test-sha1.c	…
test-sha1.sh	…
trace.c	…
tree-diff.c	…
tree-walk.c	…
tree-walk.h	Remove stale non-static-inline prototype for tree_entry_extract()	18 years ago
tree.c	…
tree.h	…
unpack-file.c	…
unpack-trees.c	…
unpack-trees.h	…
update-server-info.c	…
upload-pack.c	…
usage.c	…
utf8.c	wcwidth redeclaration	18 years ago
utf8.h	…
var.c	…
write_or_die.c	…
wt-status.c	…
wt-status.h	…
xdiff-interface.c	…
xdiff-interface.h	…

README

////////////////////////////////////////////////////////////////

	GIT - the stupid content tracker

////////////////////////////////////////////////////////////////

"git" can mean anything, depending on your mood.

 - random three-letter combination that is pronounceable, and not
   actually used by any common UNIX command.  The fact that it is a
   mispronunciation of "get" may or may not be relevant.
 - stupid. contemptible and despicable. simple. Take your pick from the
   dictionary of slang.
 - "global information tracker": you're in a good mood, and it actually
   works for you. Angels sing, and a light suddenly fills the room.
 - "goddamn idiotic truckload of sh*t": when it breaks

Git is a fast, scalable, distributed revision control system with an
unusually rich command set that provides both high-level operations
and full access to internals.

Git is an Open Source project covered by the GNU General Public License.
It was originally written by Linus Torvalds with help of a group of
hackers around the net. It is currently maintained by Junio C Hamano.

Please read the file INSTALL for installation instructions.
See Documentation/tutorial.txt to get started, then see
Documentation/everyday.txt for a useful minimum set of commands,
and "man git-commandname" for documentation of each command.
CVS users may also want to read Documentation/cvs-migration.txt.

Many Git online resources are accessible from http://git.or.cz/
including full documentation and Git related tools.

The user discussion and development of Git take place on the Git
mailing list -- everyone is welcome to post bug reports, feature
requests, comments and patches to git@vger.kernel.org. To subscribe
to the list, send an email with just "subscribe git" in the body to
majordomo@vger.kernel.org. The mailing list archives are available at
http://marc.theaimsgroup.com/?l=git and other archival sites.

The messages titled "A note from the maintainer", "What's in
git.git (stable)" and "What's cooking in git.git (topics)" and
the discussion following them on the mailing list give a good
reference for project status, development direction and
remaining tasks.