git/compat at b5d18b8e6f68746a85edfea08e9aff3351d7e891 - git

History

Ramsay Jones b5d18b8e6f Fix the exit code of MSVC build scripts on cygwin During an MSVC build on cygwin, the make program did not notice when the compiler or linker exited with an error. This was caused by the scripts exiting with the value returned by system() directly. On POSIX-like systems, such as cygwin, the return value of system() has the exit code of the executed command encoded in the first byte (ie the value is shifted up by 8 bits). This allows the bottom 7 bits to contain the signal number of a terminated process, while the eighth bit indicates whether a core-dump was produced. (A value of -1 indicates that the command failed to execute.) The make program, however, expects the exit code to be encoded in the bottom byte. Futhermore, it apparently masks off and ignores anything in the upper bytes. However, these scripts are (naturally) intended to be used on the windows platform, where we can not assume POSIX-like semantics from a perl implementation (eg ActiveState). So, in general, we can not assume that shifting the return value right by eight will get us the exit code. In order to improve portability, we assume that a zero return from system() indicates success, whereas anything else indicates failure. Since we don't need to know the exact exit code from the compiler or linker, we simply exit with 0 (success) or 1 (failure). Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>		15 years ago
..
fnmatch	Fix more typos/spelling in comments	16 years ago
nedmalloc	Fix typo in nedmalloc warning fix	16 years ago
regex	Change regerror() declaration from K&R style to ANSI C (C89)	15 years ago
vcbuild	Fix the exit code of MSVC build scripts on cygwin	15 years ago
basename.c	compat: add a basename() compatibility function	16 years ago
bswap.h	make sure byte swapping is optimal for git	16 years ago
cygwin.c	Fix more typos/spelling in comments	16 years ago
cygwin.h	cygwin: Use native Win32 API for stat	16 years ago
fopen.c	…
hstrerror.c	…
inet_ntop.c	…
inet_pton.c	…
memmem.c	optimize compat/ memmem()	16 years ago
mingw.c	Make usage of windows.h lean and mean	15 years ago
mingw.h	Make usage of windows.h lean and mean	15 years ago
mkdtemp.c	…
mkstemps.c	compat: add a mkstemps() compatibility function	16 years ago
mmap.c	…
msvc.c	Add platform files for porting to MSVC	15 years ago
msvc.h	Define strncasecmp and ftruncate for MSVC	15 years ago
pread.c	…
qsort.c	…
setenv.c	…
snprintf.c	Test for WIN32 instead of __MINGW32_	15 years ago
strcasestr.c	…
strlcpy.c	…
strtoumax.c	…
unsetenv.c	…
win32.h	Make usage of windows.h lean and mean	15 years ago
win32mmap.c	MinGW: implement mmap	16 years ago
winansi.c	Make usage of windows.h lean and mean	15 years ago