git/perl at 95a4e78a746be2b87972c03c82e8b1fe8fe0bea1 - git

Tree: 95a4e78a74

Ævar Arnfjörð Bjarmason 6798b08e84 perl Git.pm: don't ignore signalled failure in _cmd_close() Fix misbehavior in Git.pm that dates back to the very first version of the library in git.git added in `b1edc53d06` (Introduce Git.pm (v4), 2006-06-24). When we fail to execute a command we shouldn't ignore all signals, those can happen e.g. if abort() is called, or if the command segfaults. Because of this we'd consider e.g. a command that died due to LSAN exiting with abort() successful, as is the case with the tests listed as running successfully with SANITIZE=leak in `9081a421a6` (checkout: fix "branch info" memory leaks, 2021-11-16). We did run them successfully, but only because we ignored these errors. This was then made worse by the use of "abort_on_error=1" for LSAN added in `85b81b35ff` (test-lib: set LSAN_OPTIONS to abort by default, 2017-09-05). Doing that makes sense, but without providing that option we'd have a "$? >> 8" of "23" on failure, with abort_on_error=1 we'll get "0". All of our tests pass even without the SIGPIPE exception being added here, but as the code appears to have been trying to ignore it let's keep ignoring it for now. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>		3 years ago
..
FromCPAN	…
Git	…
header_templates	…
.gitignore	…
Git.pm	perl Git.pm: don't ignore signalled failure in _cmd_close()	3 years ago