git/xdiff at 8c989ec5288021e07c265882f86ac3999b44c142 - git

Tree: 8c989ec528

Marco Roeland 0ed49a3ed9 xdiff/xdiffi.c: fix warnings about possibly uninitialized variables Compiling this module gave the following warnings (some double dutch!): xdiff/xdiffi.c: In functie 'xdl_recs_cmp': xdiff/xdiffi.c:298: let op: 'spl.i1' may be used uninitialized in this function xdiff/xdiffi.c:298: let op: 'spl.i2' may be used uninitialized in this function xdiff/xdiffi.c:219: let op: 'fbest1' may be used uninitialized in this function xdiff/xdiffi.c:219: let op: 'bbest1' may be used uninitialized in this function A superficial tracking of their usage, without deeper knowledge about the algorithm, indeed confirms that there are code paths on which these variables will be used uninitialized. In practice these code paths might never be reached, but then these fixes will not change the algorithm. If these code paths are ever reached we now at least have a predictable outcome. And should the very small performance impact of these initializations be noticeable, then they should at least be replaced by comments why certain code paths will never be reached. Some extra initializations in this patch now fix the warnings.		19 years ago
..
xdiff.h	xdiff: Show function names in hunk headers.	19 years ago
xdiffi.c	xdiff/xdiffi.c: fix warnings about possibly uninitialized variables	19 years ago
xdiffi.h	…
xemit.c	xdiff: Show function names in hunk headers.	19 years ago
xemit.h	…
xinclude.h	xdiff: Show function names in hunk headers.	19 years ago
xmacros.h	…
xprepare.c	Clean-up trivially redundant diff.	19 years ago
xprepare.h	…
xtypes.h	…
xutils.c	Clean-up trivially redundant diff.	19 years ago
xutils.h	Clean-up trivially redundant diff.	19 years ago