git/reftable
Patrick Steinhardt 75d790608f reftable/stack: do not auto-compact twice in `reftable_stack_add()`
In 5c086453ff (reftable/stack: perform auto-compaction with
transactional interface, 2023-12-11), we fixed a bug where the
transactional interface to add changes to a reftable stack did not
perform auto-compaction by calling `reftable_stack_auto_compact()` in
`reftable_stack_addition_commit()`. While correct, this change may now
cause us to perform auto-compaction twice in the non-transactional
interface `reftable_stack_add()`:

  - It performs auto-compaction by itself.

  - It now transitively performs auto-compaction via the transactional
    interface.

Remove the first instance so that we only end up doing auto-compaction
once.

Reported-by: Han-Wen Nienhuys <hanwenn@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-01-03 09:54:20 -08:00
..
LICENSE
basics.c
basics.h
basics_test.c
block.c reftable/block: reuse buffer to compute record keys 2023-12-11 07:23:17 -08:00
block.h reftable/block: reuse buffer to compute record keys 2023-12-11 07:23:17 -08:00
block_test.c reftable/block: introduce macro to initialize `struct block_iter` 2023-12-11 07:23:17 -08:00
blocksource.c reftable: handle interrupted reads 2023-12-11 07:23:16 -08:00
blocksource.h
constants.h
dump.c
error.c
generic.c
generic.h
iter.c
iter.h reftable/block: introduce macro to initialize `struct block_iter` 2023-12-11 07:23:17 -08:00
merged.c reftable/merged: reuse buffer to compute record keys 2023-12-11 07:23:16 -08:00
merged.h reftable/merged: reuse buffer to compute record keys 2023-12-11 07:23:16 -08:00
merged_test.c
pq.c
pq.h
pq_test.c
publicbasics.c
reader.c reftable/block: introduce macro to initialize `struct block_iter` 2023-12-11 07:23:17 -08:00
reader.h
readwrite_test.c reftable/stack: fix use of unseeded randomness 2023-12-11 07:23:16 -08:00
record.c
record.h
record_test.c
refname.c
refname.h
refname_test.c
reftable-blocksource.h
reftable-error.h
reftable-generic.h
reftable-iterator.h
reftable-malloc.h
reftable-merged.h
reftable-reader.h
reftable-record.h
reftable-stack.h
reftable-tests.h
reftable-writer.h
stack.c reftable/stack: do not auto-compact twice in `reftable_stack_add()` 2024-01-03 09:54:20 -08:00
stack.h
stack_test.c reftable/stack: perform auto-compaction with transactional interface 2023-12-11 07:23:16 -08:00
system.h
test_framework.c
test_framework.h reftable: wrap EXPECT macros in do/while 2023-12-11 07:23:15 -08:00
tree.c
tree.h
tree_test.c
writer.c
writer.h