git/perl at 6936b5859c47b826437218fbfc0e2bc0935f7136 - git

Tree: 6936b5859c

Roman Kagan ac930287ff git-svn: workaround for a bug in svn serf backend Subversion serf backend in versions 1.8.5 and below has a bug() that the function creating the descriptor of a file change -- add_file() -- doesn't make a copy of its third argument when storing it on the returned descriptor. As a result, by the time this field is used (in transactions of file copying or renaming) it may well be released, and the memory reused. One of its possible manifestations is the svn assertion triggering on an invalid path, with a message svn_fspath__skip_ancestor: Assertion `svn_fspath__is_canonical(child_fspath)' failed. This patch works around this bug, by storing the value to be passed as the third argument to add_file() in a local variable with the same scope as the file change descriptor, making sure their lifetime is the same. [ew: fixed in Subversion r1553376 as noted by Jonathan Nieder] Cc: Benjamin Pabst <benjamin.pabst85@gmail.com> Signed-off-by: Eric Wong <normalperson@yhbt.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Roman Kagan <rkagan@mail.ru>		11 years ago
..
Git	git-svn: workaround for a bug in svn serf backend	11 years ago
.gitignore	…
Git.pm	Git.pm: revert _temp_cache use of temp_is_locked	11 years ago
Makefile	…
Makefile.PL	…
private-Error.pm	Correct common spelling mistakes in comments and tests	12 years ago