git/coccinelle at 4a7e27e95797c0a094f8ee300a260777ddd7eec9 - git

Tree: 4a7e27e957

Jeff King 4a7e27e957 convert "oidcmp() == 0" to oideq() Using the more restrictive oideq() should, in the long run, give the compiler more opportunities to optimize these callsites. For now, this conversion should be a complete noop with respect to the generated code. The result is also perhaps a little more readable, as it avoids the "zero is equal" idiom. Since it's so prevalent in C, I think seasoned programmers tend not to even notice it anymore, but it can sometimes make for awkward double negations (e.g., we can drop a few !!oidcmp() instances here). This patch was generated almost entirely by the included coccinelle patch. This mechanical conversion should be completely safe, because we check explicitly for cases where oidcmp() is compared to 0, which is what oideq() is doing under the hood. Note that we don't have to catch "!oidcmp()" separately; coccinelle's standard isomorphisms make sure the two are treated equivalently. I say "almost" because I did hand-edit the coccinelle output to fix up a few style violations (it mostly keeps the original formatting, but sometimes unwraps long lines). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		6 years ago
..
.gitignore	…
README	…
array.cocci	…
commit.cocci	coccinelle: use <...> for function exclusion	6 years ago
free.cocci	…
object_id.cocci	convert "oidcmp() == 0" to oideq()	6 years ago
qsort.cocci	…
strbuf.cocci	…
swap.cocci	…
xstrdup_or_null.cocci	…

This directory provides examples of Coccinelle (http://coccinelle.lip6.fr/)
semantic patches that might be useful to developers.