Go to file
Taylor Blau 03c7a30cee pack-bitmap: reject pseudo-merge "sampleRate" of 0
The "bitmapPseudoMerge.*.sampleRate" configuration controls what
fraction of unstable commits are included in each pseudo-merge group.
The config validation accepts values in the range `[0, 1]`, but a value
of exactly 0 causes a division by zero in `select_pseudo_merges_1()`:

    if (j % (uint32_t)(1.0 / group->sample_rate))

When `sample_rate` is 0, `1.0 / 0.0` produces `+inf`, and casting
infinity to `uint32_t` is undefined behavior in C. On most platforms
this yields 0, making the subsequent modulo operation (`j % 0`) a
fatal arithmetic trap.

This path was not previously reachable because an earlier bug caused
all pseudo-merge candidates to be classified as "stable" (where the
sampling rate is not used), regardless of their actual commit date. Now
that the date classification is fixed, the unstable path is exercised
and the division by zero can fire.

Fix this by changing the validation to require a strict lower bound and
thus reject 0.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2026-05-12 10:36:18 +09:00
.github
Documentation pack-bitmap: reject pseudo-merge "sampleRate" of 0 2026-05-12 10:36:18 +09:00
bin-wrappers
block-sha1
builtin Merge branch 'ds/rev-list-maximal-only-optim' 2026-04-09 11:21:59 -07:00
ci Merge branch 'ps/build-tweaks' 2026-03-27 11:00:01 -07:00
compat Revert "compat/posix: introduce writev(3p) wrapper" 2026-04-09 14:48:24 -07:00
compiler-tricks
contrib Revert "cmake: use writev(3p) wrapper as needed" 2026-04-09 14:47:28 -07:00
ewah
git-gui
gitk-git
gitweb
mergetools
negotiator
odb odb: use enum for `odb_write_object` flags 2026-03-31 20:43:13 -07:00
oss-fuzz
perl
po
refs Merge branch 'jk/c23-const-preserving-fixes-more' 2026-04-09 11:21:59 -07:00
reftable reftable/system: add abstraction to mmap files 2026-04-02 10:45:44 -07:00
sha1
sha1collisiondetection@855827c583
sha1dc
sha256
src
subprojects
t pack-bitmap: reject pseudo-merge "sampleRate" of 0 2026-05-12 10:36:18 +09:00
templates
tools Merge branch 'rs/use-strvec-pushv' 2026-04-01 10:28:19 -07:00
trace2
xdiff
.cirrus.yml
.clang-format
.editorconfig
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.mailmap
.tsan-suppressions
CODE_OF_CONDUCT.md
COPYING
Cargo.toml
GIT-BUILD-OPTIONS.in
GIT-VERSION-FILE.in
GIT-VERSION-GEN Git 2.54-rc1 2026-04-08 08:21:34 -07:00
INSTALL
LGPL-2.1
Makefile Revert "compat/posix: introduce writev(3p) wrapper" 2026-04-09 14:48:24 -07:00
README.md
RelNotes
SECURITY.md
abspath.c
abspath.h
aclocal.m4
add-interactive.c
add-interactive.h
add-patch.c Merge branch 'sp/add-patch-with-fewer-the-repository' 2026-04-07 14:59:26 -07:00
add-patch.h
advice.c
advice.h
alias.c
alias.h
alloc.c
alloc.h
apply.c Merge branch 'jc/whitespace-incomplete-line' 2026-04-07 14:59:26 -07:00
apply.h
archive-tar.c
archive-zip.c
archive.c
archive.h
attr.c
attr.h
banned.h
base85.c
base85.h
bisect.c
bisect.h
blame.c
blame.h
blob.c
blob.h
bloom.c
bloom.h
branch.c
branch.h
build.rs
builtin.h
bundle-uri.c
bundle-uri.h
bundle.c
bundle.h
cache-tree.c Merge branch 'jd/cache-tree-trace-wo-the-repository' 2026-04-08 10:19:17 -07:00
cache-tree.h
cbtree.c
cbtree.h
chdir-notify.c
chdir-notify.h
checkout.c
checkout.h
chunk-format.c
chunk-format.h
color.c
color.h
column.c
column.h
combine-diff.c
command-list.txt
commit-graph.c Merge branch 'ps/commit-graph-overflow-fix' 2026-04-07 14:59:25 -07:00
commit-graph.h
commit-reach.c
commit-reach.h
commit-slab-decl.h
commit-slab-impl.h
commit-slab.h
commit.c
commit.h
common-exit.c
common-init.c
common-init.h
common-main.c
config.c
config.h
config.mak.dev
config.mak.in
config.mak.uname Revert "compat/posix: introduce writev(3p) wrapper" 2026-04-09 14:48:24 -07:00
configure.ac
connect.c
connect.h
connected.c
connected.h
convert.c convert: add const to fix strchr() warnings 2026-04-01 22:08:50 -07:00
convert.h
copy.c
copy.h
credential.c
credential.h
csum-file.c
csum-file.h
ctype.c
daemon.c
date.c
date.h
decorate.c
decorate.h
delta-islands.c
delta-islands.h
delta.h
diagnose.c
diagnose.h
diff-delta.c
diff-lib.c
diff-merges.c
diff-merges.h
diff-no-index.c
diff.c Merge branch 'mm/line-log-use-standard-diff-output' 2026-04-07 14:59:27 -07:00
diff.h
diffcore-break.c
diffcore-delta.c
diffcore-order.c
diffcore-pickaxe.c
diffcore-rename.c
diffcore-rotate.c
diffcore.h
dir-iterator.c
dir-iterator.h
dir.c
dir.h
editor.c
editor.h
entry.c
entry.h
environment.c
environment.h
exec-cmd.c
exec-cmd.h
fetch-negotiator.c
fetch-negotiator.h
fetch-pack.c Merge branch 'ps/odb-cleanup' 2026-04-08 10:19:17 -07:00
fetch-pack.h
fmt-merge-msg.c
fmt-merge-msg.h
for-each-ref.h
fsck.c
fsck.h
fsmonitor--daemon.h
fsmonitor-ipc.c
fsmonitor-ipc.h
fsmonitor-ll.h
fsmonitor-path-utils.h
fsmonitor-settings.c
fsmonitor-settings.h
fsmonitor.c
fsmonitor.h
gettext.c
gettext.h
git-archimport.perl
git-compat-util.h git-compat-util: fix CONST_OUTPARAM typo and indentation 2026-04-06 08:22:57 -07:00
git-curl-compat.h
git-cvsexportcommit.perl
git-cvsimport.perl
git-cvsserver.perl
git-difftool--helper.sh
git-filter-branch.sh
git-instaweb.sh
git-merge-octopus.sh
git-merge-one-file.sh
git-merge-resolve.sh
git-mergetool--lib.sh
git-mergetool.sh
git-p4.py
git-quiltimport.sh
git-request-pull.sh
git-send-email.perl
git-sh-i18n.sh
git-sh-setup.sh
git-submodule.sh
git-svn.perl
git-web--browse.sh
git-zlib.c
git-zlib.h
git.c
git.rc.in
gpg-interface.c fast-import: add 'abort-if-invalid' mode to '--signed-commits=<mode>' 2026-03-26 12:42:57 -07:00
gpg-interface.h fast-import: add 'abort-if-invalid' mode to '--signed-commits=<mode>' 2026-03-26 12:42:57 -07:00
graph.c
graph.h
grep.c
grep.h
hash-lookup.c
hash-lookup.h
hash.c
hash.h
hashmap.c
hashmap.h
help.c
help.h
hex-ll.c
hex-ll.h
hex.c refs/files-backend: drop const to fix strchr() warning 2026-04-01 22:08:53 -07:00
hex.h refs/files-backend: drop const to fix strchr() warning 2026-04-01 22:08:53 -07:00
hook.c hook: show disabled hooks in "git hook list" 2026-03-25 14:00:47 -07:00
hook.h hook: show disabled hooks in "git hook list" 2026-03-25 14:00:47 -07:00
http-backend.c
http-fetch.c
http-push.c Merge branch 'jk/c23-const-preserving-fixes-more' 2026-04-09 11:21:59 -07:00
http-walker.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
http.c Merge branch 'jk/c23-const-preserving-fixes-more' 2026-04-09 11:21:59 -07:00
http.h
ident.c
ident.h
imap-send.c
iterator.h
json-writer.c
json-writer.h
khash.h
kwset.c
kwset.h
levenshtein.c
levenshtein.h
line-log.c
line-log.h
line-range.c
line-range.h
linear-assignment.c
linear-assignment.h
list-objects-filter-options.c
list-objects-filter-options.h
list-objects-filter.c
list-objects-filter.h
list-objects.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
list-objects.h
list.h
lockfile.c
lockfile.h
log-tree.c
log-tree.h
loose.c
loose.h
ls-refs.c
ls-refs.h
mailinfo.c Merge branch 'vp/http-rate-limit-retries' 2026-04-01 10:28:18 -07:00
mailinfo.h
mailmap.c
mailmap.h
match-trees.c
match-trees.h
mem-pool.c
mem-pool.h
merge-blobs.c
merge-blobs.h
merge-ll.c
merge-ll.h
merge-ort-wrappers.c
merge-ort-wrappers.h
merge-ort.c
merge-ort.h
merge.c
merge.h
mergesort.h
meson.build Revert "compat/posix: introduce writev(3p) wrapper" 2026-04-09 14:48:24 -07:00
meson_options.txt
midx-write.c
midx.c
midx.h
name-hash.c
name-hash.h
notes-cache.c
notes-cache.h
notes-merge.c
notes-merge.h
notes-utils.c
notes-utils.h
notes.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
notes.h
object-file-convert.c
object-file-convert.h
object-file.c Merge branch 'jt/index-fd-wo-repo-regression-fix-maint' 2026-04-08 10:20:51 -07:00
object-file.h odb: use enum for `odb_write_object` flags 2026-03-31 20:43:13 -07:00
object-name.c Merge branch 'ps/odb-generic-object-name-handling' 2026-04-06 15:42:49 -07:00
object-name.h
object.c
object.h
odb.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
odb.h odb: drop unneeded headers and forward decls 2026-03-31 20:43:14 -07:00
oid-array.c
oid-array.h
oidmap.c
oidmap.h
oidset.c
oidset.h
oidtree.c
oidtree.h
pack-bitmap-write.c pack-bitmap: fix pseudo-merge lookup for shared commits 2026-05-12 10:36:18 +09:00
pack-bitmap.c
pack-bitmap.h
pack-check.c
pack-mtimes.c
pack-mtimes.h
pack-objects.c
pack-objects.h
pack-refs.c
pack-refs.h
pack-revindex.c
pack-revindex.h
pack-write.c
pack.h
packfile.c Merge branch 'ps/odb-cleanup' 2026-04-08 10:19:17 -07:00
packfile.h Merge branch 'ps/odb-cleanup' 2026-04-08 10:19:17 -07:00
pager.c pager: explicitly cast away strchr() constness 2026-04-01 22:08:51 -07:00
pager.h
parallel-checkout.c
parallel-checkout.h
parse-options-cb.c
parse-options.c
parse-options.h
parse.c
parse.h
patch-delta.c
patch-ids.c
patch-ids.h
path-walk.c Merge branch 'yc/path-walk-fix-error-reporting' 2026-04-07 14:59:26 -07:00
path-walk.h
path.c backfill: work with prefix pathspecs 2026-03-26 09:38:06 -07:00
path.h backfill: work with prefix pathspecs 2026-03-26 09:38:06 -07:00
pathspec.c
pathspec.h
pkt-line.c
pkt-line.h pkt-line: make packet_reader.line non-const 2026-04-01 22:08:52 -07:00
preload-index.c
preload-index.h
pretty.c Merge branch 'mf/format-patch-cover-letter-format' 2026-04-03 13:01:08 -07:00
pretty.h
prio-queue.c
prio-queue.h
progress.c
progress.h
promisor-remote.c
promisor-remote.h
prompt.c
prompt.h
protocol-caps.c
protocol-caps.h
protocol.c
protocol.h
prune-packed.c
prune-packed.h
pseudo-merge.c pack-bitmap: reject pseudo-merge "sampleRate" of 0 2026-05-12 10:36:18 +09:00
pseudo-merge.h
quote.c
quote.h
range-diff.c range-diff: drop const to fix strstr() warnings 2026-04-01 22:08:53 -07:00
range-diff.h
reachable.c
reachable.h
read-cache-ll.h
read-cache.c Merge branch 'ng/add-files-to-cache-wo-rename' 2026-04-08 10:19:18 -07:00
read-cache.h
rebase-interactive.c
rebase-interactive.h
rebase.c
rebase.h
ref-filter.c
ref-filter.h
reflog-walk.c
reflog-walk.h
reflog.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
reflog.h
refs.c Merge branch 'ps/odb-cleanup' 2026-04-08 10:19:17 -07:00
refs.h
refspec.c
refspec.h
remote-curl.c Merge branch 'kj/refspec-parsing-outside-repository' 2026-04-01 10:28:19 -07:00
remote.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
remote.h
repack-cruft.c
repack-filtered.c
repack-geometry.c
repack-midx.c
repack-promisor.c
repack.c
repack.h
replace-object.c
replace-object.h
replay.c Merge branch 'tc/replay-ref' 2026-04-08 10:19:18 -07:00
replay.h replay: allow to specify a ref with option --ref 2026-04-01 21:34:25 -07:00
repo-settings.c
repo-settings.h
repository.c
repository.h
rerere.c Merge branch 'jc/rerere-modern-strbuf-handling' 2026-03-27 11:00:03 -07:00
rerere.h
reset.c
reset.h
resolve-undo.c
resolve-undo.h
revision.c Merge branch 'mm/line-log-use-standard-diff-output' 2026-04-07 14:59:27 -07:00
revision.h revision: include object-name.h 2026-03-26 09:38:06 -07:00
run-command.c Merge branch 'jk/c23-const-preserving-fixes-more' 2026-04-09 11:21:59 -07:00
run-command.h
sane-ctype.h
scalar.c
send-pack.c pkt-line: make packet_reader.line non-const 2026-04-01 22:08:52 -07:00
send-pack.h
sequencer.c Merge branch 'sa/replay-revert' 2026-04-03 13:01:09 -07:00
sequencer.h Merge branch 'sa/replay-revert' 2026-04-03 13:01:09 -07:00
serve.c
serve.h
server-info.c
server-info.h
setup.c
setup.h
sh-i18n--envsubst.c
sha1dc_git.c
sha1dc_git.h
shallow.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
shallow.h
shared.mak
shell.c
shortlog.h
sideband.c Revert "sideband: use writev(3p) to send pktlines" 2026-04-09 14:47:51 -07:00
sideband.h
sigchain.c
sigchain.h
simple-ipc.h
sparse-index.c
sparse-index.h
split-index.c
split-index.h
stable-qsort.c
statinfo.c
statinfo.h
strbuf.c Merge branch 'vp/http-rate-limit-retries' 2026-04-01 10:28:18 -07:00
strbuf.h
string-list.c
string-list.h
strmap.c
strmap.h
strvec.c
strvec.h
sub-process.c
sub-process.h
submodule-config.c
submodule-config.h
submodule.c Merge branch 'rs/use-strvec-pushv' 2026-04-01 10:28:19 -07:00
submodule.h
symlinks.c
symlinks.h
tag.c
tag.h
tar.h
tempfile.c
tempfile.h
thread-utils.c
thread-utils.h
tmp-objdir.c
tmp-objdir.h
trace.c
trace.h
trace2.c
trace2.h
trailer.c Merge branch 'vp/http-rate-limit-retries' 2026-04-01 10:28:18 -07:00
trailer.h
transport-helper.c Merge branch 'jk/c23-const-preserving-fixes-more' 2026-04-09 11:21:59 -07:00
transport-internal.h
transport.c Merge branch 'ar/config-hook-cleanups' 2026-04-03 13:01:09 -07:00
transport.h
tree-diff.c
tree-walk.c
tree-walk.h
tree.c
tree.h
unicode-width.h
unimplemented.sh
unix-socket.c
unix-socket.h
unix-stream-server.c
unix-stream-server.h
unpack-trees.c
unpack-trees.h
upload-pack.c
upload-pack.h
url.c
url.h
urlmatch.c
urlmatch.h
usage.c
userdiff.c
userdiff.h
utf8.c
utf8.h
varint.c
varint.h
version-def.h.in
version.c
version.h
versioncmp.c
versioncmp.h
walker.c odb: rename `odb_has_object()` flags 2026-03-31 20:43:14 -07:00
walker.h
wildmatch.c
wildmatch.h
worktree.c Merge branch 'pw/worktree-reduce-the-repository' 2026-04-03 13:01:09 -07:00
worktree.h Merge branch 'pw/worktree-reduce-the-repository' 2026-04-03 13:01:09 -07:00
wrapper.c Revert "wrapper: introduce writev(3p) wrappers" 2026-04-09 14:48:09 -07:00
wrapper.h Revert "wrapper: introduce writev(3p) wrappers" 2026-04-09 14:48:09 -07:00
write-or-die.c Revert "wrapper: introduce writev(3p) wrappers" 2026-04-09 14:48:09 -07:00
write-or-die.h Revert "wrapper: introduce writev(3p) wrappers" 2026-04-09 14:48:09 -07:00
ws.c
ws.h
wt-status.c
wt-status.h
xdiff-interface.c
xdiff-interface.h

README.md

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks