kernel/git - git - PowerEL Git System

62415 Commits

6 Branches

36 Tags

131 MiB

Tree: 38fc4dbbc2

Commit Graph

Author	SHA1	Message	Date
Junio C Hamano	05b4ed61f4	cocci: simplify "if (++u > 1)" to "if (u++)" It is more common to use post-increment than pre-increment when the side effect is the primary thing we want in our code and in C in general (unlike C++). Initializing a variable to 0, incrementing it every time we do something, and checking if we have already done that thing to guard the code to do that thing, is easier to understand when written if (u++) ; /* we've done that! / else do_it(); / just once. */ but if you try to use pre-increment, you end up with a less natural looking if (++u > 1) Signed-off-by: Junio C Hamano <gitster@pobox.com>	6 years ago

Author

SHA1

Message

Date

Junio C Hamano

05b4ed61f4

cocci: simplify "if (++u > 1)" to "if (u++)"

It is more common to use post-increment than pre-increment when the
side effect is the primary thing we want in our code and in C in
general (unlike C++).

Initializing a variable to 0, incrementing it every time we do
something, and checking if we have already done that thing to guard
the code to do that thing, is easier to understand when written

	if (u++)
		; /* we've done that! */
	else
		do_it(); /* just once. */

but if you try to use pre-increment, you end up with a less natural
looking

	if (++u > 1)

Signed-off-by: Junio C Hamano <gitster@pobox.com>

6 years ago

1 Commits (38fc4dbbc2f110192752a3b2c99abb745f0494bf)