Browse Source

bugreport.c: replace strbuf_write_fd with write_in_full

The strbuf_write_fd method did not provide checks for buffers larger
than MAX_IO_SIZE. Replacing with write_in_full ensures the entire
buffer will always be written to disk or report an error and die.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Randall S. Becker 5 years ago committed by Junio C Hamano
parent
commit
f64b6a1f75
  1. 4
      bugreport.c

4
bugreport.c

@ -122,7 +122,9 @@ int cmd_main(int argc, const char **argv) @@ -122,7 +122,9 @@ int cmd_main(int argc, const char **argv)
die(_("couldn't create a new file at '%s'"), report_path.buf);
}

strbuf_write_fd(&buffer, report);
if (write_in_full(report, buffer.buf, buffer.len) < 0)
die_errno(_("unable to write to %s"), report_path.buf);

close(report);

/*

Loading…
Cancel
Save