Browse Source

Merge branch 'maint'

* maint:
  diff.c: plug a memory leak in an error path
  fetch-pack: close output channel after sideband demultiplexer terminates
  builtin-remote: Make "remote show" display all urls
maint
Junio C Hamano 16 years ago
parent
commit
f4f78e668d
  1. 4
      builtin-fetch-pack.c
  2. 9
      builtin-remote.c
  3. 1
      diff.c

4
builtin-fetch-pack.c

@ -483,7 +483,9 @@ static int sideband_demux(int fd, void *data)
{ {
int *xd = data; int *xd = data;


return recv_sideband("fetch-pack", xd[0], fd); int ret = recv_sideband("fetch-pack", xd[0], fd);
close(fd);
return ret;
} }


static int get_pack(int xd[2], char **pack_lockfile) static int get_pack(int xd[2], char **pack_lockfile)

9
builtin-remote.c

@ -1005,9 +1005,12 @@ static int show(int argc, const char **argv)


get_remote_ref_states(*argv, &states, query_flag); get_remote_ref_states(*argv, &states, query_flag);


printf("* remote %s\n URL: %s\n", *argv, printf("* remote %s\n", *argv);
states.remote->url_nr > 0 ? if (states.remote->url_nr) {
states.remote->url[0] : "(no URL)"); for (i=0; i < states.remote->url_nr; i++)
printf(" URL: %s\n", states.remote->url[i]);
} else
printf(" URL: %s\n", "(no URL)");
if (no_query) if (no_query)
printf(" HEAD branch: (not queried)\n"); printf(" HEAD branch: (not queried)\n");
else if (!states.heads.nr) else if (!states.heads.nr)

1
diff.c

@ -3596,6 +3596,7 @@ static char *run_textconv(const char *pgm, struct diff_filespec *spec,
if (start_command(&child) != 0 || if (start_command(&child) != 0 ||
strbuf_read(&buf, child.out, 0) < 0 || strbuf_read(&buf, child.out, 0) < 0 ||
finish_command(&child) != 0) { finish_command(&child) != 0) {
strbuf_release(&buf);
remove_tempfile(); remove_tempfile();
error("error running textconv command '%s'", pgm); error("error running textconv command '%s'", pgm);
return NULL; return NULL;

Loading…
Cancel
Save