kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

t/gitweb-lib.sh: drop confusing quotes 

Some variables assignments in gitweb_run() look like this:

  FOO=""$1""

The extra quotes aren't doing anything. Each set opens and closes an
empty string, and $1 is actually outside of any double-quotes (which is
OK, because variable assignment does not do whitespace splitting on the
expanded value).

Let's drop them, as they're simply confusing.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 2019-11-15 04:06:01 -05:00 committed by Junio C Hamano
parent 0eba60c9b7
commit f28bceca75
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/gitweb-lib.sh
View File

@ -58,8 +58,8 @@ gitweb_run () {
GATEWAY_INTERFACE='CGI/1.1' GATEWAY_INTERFACE='CGI/1.1'
HTTP_ACCEPT='*/*' HTTP_ACCEPT='*/*'
REQUEST_METHOD='GET' REQUEST_METHOD='GET'
QUERY_STRING=""$1"" QUERY_STRING=$1
PATH_INFO=""$2"" PATH_INFO=$2
export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \ export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
QUERY_STRING PATH_INFO QUERY_STRING PATH_INFO