Browse Source

get_sha1_basic(): fix invalid memory access, found by valgrind

When get_sha1_basic() is passed a buffer of len 0, it should not
check if buf[len-1] is a curly bracket.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Johannes Schindelin 16 years ago committed by Junio C Hamano
parent
commit
f265458f61
  1. 2
      sha1_name.c

2
sha1_name.c

@ -309,7 +309,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1) @@ -309,7 +309,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)

/* basic@{time or number} format to query ref-log */
reflog_len = at = 0;
if (str[len-1] == '}') {
if (len && str[len-1] == '}') {
for (at = 0; at < len - 1; at++) {
if (str[at] == '@' && str[at+1] == '{') {
reflog_len = (len-1) - (at+2);

Loading…
Cancel
Save