Browse Source

t6429: fix use of non-existent function

This test had a line reading

    ! test_file_is_empty actual

which was meant to be

    ! test_must_be_empty actual

The test worked despite the error, because even though
test_file_is_empty is a non-existent function, the '!' negated the
return value and made it pass.  It'd be better to avoid the negation,
so something like

    test_file_not_empty actual

would be better, but perhaps it makes even more sense to specify the
number of lines of expected output to make the test a bit tighter.

Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Elijah Newren <newren@palantir.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Elijah Newren 3 years ago committed by Junio C Hamano
parent
commit
ec2f6c0cca
  1. 2
      t/t6429-merge-sequence-rename-caching.sh

2
t/t6429-merge-sequence-rename-caching.sh

@ -760,7 +760,7 @@ test_expect_success 'avoid assuming we detected renames' ' @@ -760,7 +760,7 @@ test_expect_success 'avoid assuming we detected renames' '
test_must_fail git -c merge.renameLimit=1 rebase upstream &&

git ls-files -u >actual &&
! test_file_is_empty actual
test_line_count = 2 actual
)
'


Loading…
Cancel
Save