Browse Source

Cleanup git-send-email.perl:extract_valid_email

- Fix the regular expressions for local addresses
- Fix the fallback regexp for non-local addresses, simplify the logic

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Horst H. von Brand 19 years ago committed by Junio C Hamano
parent
commit
e96fd30553
  1. 9
      git-send-email.perl

9
git-send-email.perl

@ -314,18 +314,15 @@ sub extract_valid_address { @@ -314,18 +314,15 @@ sub extract_valid_address {
my $address = shift;

# check for a local address:
return $address if ($address =~ /^([\w\-]+)$/);
return $address if ($address =~ /^([\w\-.]+)$/);

if ($have_email_valid) {
return Email::Valid->address($address);
} else {
# less robust/correct than the monster regexp in Email::Valid,
# but still does a 99% job, and one less dependency
my $cleaned_address;
if ($address =~ /([^\"<>\s]+@[^<>\s]+)/) {
$cleaned_address = $1;
}
return $cleaned_address;
$address =~ /([\w\-.]+@[\w\-.]+)/;
return $1;
}
}


Loading…
Cancel
Save