kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

builtin/maintenance: improve readability of strategies 

Our maintenance strategies are essentially a large array of structures,
where each of the tasks can be enabled and scheduled individually. With
the current layout though all the configuration sits on the same nesting
layer, which makes it a bit hard to discern which initialized fields
belong to what task.

Improve readability of the individual tasks by using nested designated
initializers instead.

Suggested-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Acked-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
main
Patrick Steinhardt 2025-10-24 08:57:19 +02:00 committed by Junio C Hamano
parent d465be2327
commit e83e92e876
1 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
builtin/gc.c
View File

@ -1835,23 +1835,37 @@ struct maintenance_strategy {
};

static const struct maintenance_strategy none_strategy = { 0 };

static const struct maintenance_strategy default_strategy = {
.tasks = {
[TASK_GC].enabled = 1,
[TASK_GC] = {
.enabled = 1,
},
},
};

static const struct maintenance_strategy incremental_strategy = {
.tasks = {
[TASK_COMMIT_GRAPH].enabled = 1,
[TASK_COMMIT_GRAPH].schedule = SCHEDULE_HOURLY,
[TASK_PREFETCH].enabled = 1,
[TASK_PREFETCH].schedule = SCHEDULE_HOURLY,
[TASK_INCREMENTAL_REPACK].enabled = 1,
[TASK_INCREMENTAL_REPACK].schedule = SCHEDULE_DAILY,
[TASK_LOOSE_OBJECTS].enabled = 1,
[TASK_LOOSE_OBJECTS].schedule = SCHEDULE_DAILY,
[TASK_PACK_REFS].enabled = 1,
[TASK_PACK_REFS].schedule = SCHEDULE_WEEKLY,
[TASK_COMMIT_GRAPH] = {
.enabled = 1,
.schedule = SCHEDULE_HOURLY,
},
[TASK_PREFETCH] = {
.enabled = 1,
.schedule = SCHEDULE_HOURLY,
},
[TASK_INCREMENTAL_REPACK] = {
.enabled = 1,
.schedule = SCHEDULE_DAILY,
},
[TASK_LOOSE_OBJECTS] = {
.enabled = 1,
.schedule = SCHEDULE_DAILY,
},
[TASK_PACK_REFS] = {
.enabled = 1,
.schedule = SCHEDULE_WEEKLY,
},
},
};