From e7297a1c5fd1133134e78a775e8b87d7679fb526 Mon Sep 17 00:00:00 2001 From: Paul Mackerras Date: Tue, 15 Jan 2008 22:30:40 +1100 Subject: [PATCH] gitk: Fix bug where editing an existing view would cause an infinite loop This fixes a bug where changing the commit range or file list for an existing view and then clicking OK would cause gitk to go into an infinite loop. The problem was that newviewok was invoking reloadcommits via "run reloadcommits", but reloadcommits wasn't explicitly returning 0, and whatever it was returning was causing dorunq to run it over and over again. This fixes it by making reloadcommits return 0. Signed-off-by: Paul Mackerras --- gitk | 1 + 1 file changed, 1 insertion(+) diff --git a/gitk b/gitk index c707c3c104..322ac93f86 100755 --- a/gitk +++ b/gitk @@ -263,6 +263,7 @@ proc reloadcommits {} { catch {unset targetid} setcanvscroll getcommits + return 0 } # This makes a string representation of a positive integer which