From 4340a709bf5ba4b2919a9993722ba5703b0999b4 Mon Sep 17 00:00:00 2001 From: Patrick Steinhardt Date: Tue, 1 Sep 2026 10:16:11 +0200 Subject: [PATCH 1/2] ci: fix missing Ruby dependency in "documentation" job Our "documentation" job has recently stopped working with the following error: + sudo gem install --version 1.5.8 asciidoctor + gem install --version 1.5.8 asciidoctor ./ci/install-dependencies.sh: 23: gem: not found The root cause of this is that we never explicitly install Ruby, and consequently gem(1) isn't explicitly pulled in, either. This used to work alright because we transitively pulled in Ruby via asciidoc. But due to an update it seems that we stopped pulling in the transitive dependency, and consequently we don't have gem(1) available anymore. Fix this by explicitly installing Ruby. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- ci/install-dependencies.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 10c3530d1a..502e518077 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -164,7 +164,7 @@ sparse) libexpat-dev gettext zlib1g-dev sparse ;; Documentation) - sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make + sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby test -n "$ALREADY_HAVE_ASCIIDOCTOR" || sudo gem install --version 1.5.8 asciidoctor From 1c1eed13bdeba8c97c121e250e37995506344e68 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 2 Sep 2026 03:14:09 -0400 Subject: [PATCH 2/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable Our install-dependencies script avoids installing asciidoctor if the CI environment claims to have it already. But the only environment which made use of this was Azure Pipelines, which went away in 6081d3898f (ci: retire the Azure Pipelines definition, 2020-04-11). So this conditional was effectively doing nothing. Let's clean it up. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- ci/install-dependencies.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 502e518077..2f61fbb07c 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -166,7 +166,6 @@ sparse) Documentation) sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby - test -n "$ALREADY_HAVE_ASCIIDOCTOR" || sudo gem install --version 1.5.8 asciidoctor sudo gem install concurrent-ruby ;;