Browse Source

resolve_ref_1(): reorder code

There is no need to adjust *flags if we're just about to fail.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: David Turner <dturner@twopensource.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Michael Haggerty 9 years ago committed by Junio C Hamano
parent
commit
e6702e570b
  1. 4
      refs/files-backend.c

4
refs/files-backend.c

@ -1542,13 +1542,13 @@ static const char *resolve_ref_1(const char *refname, @@ -1542,13 +1542,13 @@ static const char *resolve_ref_1(const char *refname,
return refname;
}
if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
*flags |= REF_ISBROKEN;

if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
!refname_is_safe(refname)) {
errno = EINVAL;
return NULL;
}

*flags |= REF_ISBROKEN;
bad_name = 1;
}
}

Loading…
Cancel
Save