kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Remove pointless calls to access(2) when checking for .mailmap 

read_mailmap already returns not 0 in case of error, and nothing
seem to be interested in it. It also is silent about the fact
(read_mailmap being to chatty would justify the call to access,
but there is no point for it to be and it isn't).

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Alex Riesen 2007-05-01 00:27:05 +02:00 committed by Junio C Hamano
parent 8503ee4394
commit e44b5d106c
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin-blame.c
View File

@ -2375,7 +2375,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
die("reading graft file %s failed: %s", die("reading graft file %s failed: %s",
revs_file, strerror(errno)); revs_file, strerror(errno));


if (!no_mailmap && !access(".mailmap", R_OK)) if (!no_mailmap)
read_mailmap(&mailmap, ".mailmap", NULL); read_mailmap(&mailmap, ".mailmap", NULL);


assign_blame(&sb, &revs, opt); assign_blame(&sb, &revs, opt);

1
builtin-shortlog.c
View File

@ -283,7 +283,6 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
if (argc > 1) if (argc > 1)
die ("unrecognized argument: %s", argv[1]); die ("unrecognized argument: %s", argv[1]);


if (!access(".mailmap", R_OK))
read_mailmap(&mailmap, ".mailmap", &common_repo_prefix); read_mailmap(&mailmap, ".mailmap", &common_repo_prefix);


if (rev.pending.nr == 0) { if (rev.pending.nr == 0) {