Browse Source

pack-bitmap: clarify comment in filter_bitmap_exclude_type()

The code that eventually became filter_bitmap_exclude_type() was
originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE
filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps.

In 856e12c18a (pack-bitmap.c: make object filtering functions generic,
2020-05-04), it became filter_bitmap_exclude_type(). But not all of the
comments were updated to be agnostic to the provided type.

Remove the remaining comments which should have been updated in
856e12c18a to reflect the type-agnostic nature of the function.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Taylor Blau 4 years ago committed by Junio C Hamano
parent
commit
ddcb189d9d
  1. 11
      pack-bitmap.c

11
pack-bitmap.c

@ -762,8 +762,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git, @@ -762,8 +762,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
tips = find_tip_objects(bitmap_git, tip_objects, type);

/*
* We can use the blob type-bitmap to work in whole words
* for the objects that are actually in the bitmapped packfile.
* We can use the type-level bitmap for 'type' to work in whole
* words for the objects that are actually in the bitmapped
* packfile.
*/
for (i = 0, init_type_iterator(&it, bitmap_git, type);
i < to_filter->word_alloc && ewah_iterator_next(&mask, &it);
@ -774,9 +775,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git, @@ -774,9 +775,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
}

/*
* Clear any blobs that weren't in the packfile (and so would not have
* been caught by the loop above. We'll have to check them
* individually.
* Clear any objects that weren't in the packfile (and so would
* not have been caught by the loop above. We'll have to check
* them individually.
*/
for (i = 0; i < eindex->count; i++) {
uint32_t pos = i + bitmap_git->pack->num_objects;

Loading…
Cancel
Save