kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

read-cache: convert post-index-change to use hook.h 

Move the post-index-change hook away from run-command.h to and over to
the new hook.h library.

This removes the last direct user of "run_hook_ve()" outside of
run-command.c ("run_hook_le()" still uses it). So we can make the
function static now. A subsequent commit will remove this code
entirely when "run_hook_le()" itself goes away.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Emily Shaffer <emilyshaffer@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Emily Shaffer 2021-12-22 04:59:41 +01:00 committed by Junio C Hamano
parent f443246b9f
commit dbb1c61365
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
read-cache.c
View File

@ -28,6 +28,7 @@
#include "sparse-index.h" #include "sparse-index.h"
#include "csum-file.h" #include "csum-file.h"
#include "promisor-remote.h" #include "promisor-remote.h"
#include "hook.h"


/* Mask for the name length in ce_flags in the on-disk index */ /* Mask for the name length in ce_flags in the on-disk index */


@ -3150,7 +3151,7 @@ static int do_write_locked_index(struct index_state *istate, struct lock_file *l
else else
ret = close_lock_file_gently(lock); ret = close_lock_file_gently(lock);


run_hook_le(NULL, "post-index-change", run_hooks_l("post-index-change",
istate->updated_workdir ? "1" : "0", istate->updated_workdir ? "1" : "0",
istate->updated_skipworktree ? "1" : "0", NULL); istate->updated_skipworktree ? "1" : "0", NULL);
istate->updated_workdir = 0; istate->updated_workdir = 0;

2
run-command.c
View File

@ -1313,7 +1313,7 @@ int async_with_fork(void)
#endif #endif
} }


int run_hook_ve(const char *const *env, const char *name, va_list args) static int run_hook_ve(const char *const *env, const char *name, va_list args)
{ {
struct child_process hook = CHILD_PROCESS_INIT; struct child_process hook = CHILD_PROCESS_INIT;
const char *p; const char *p;

1
run-command.h
View File

@ -235,7 +235,6 @@ int run_command(struct child_process *);
*/ */
LAST_ARG_MUST_BE_NULL LAST_ARG_MUST_BE_NULL
int run_hook_le(const char *const *env, const char *name, ...); int run_hook_le(const char *const *env, const char *name, ...);
int run_hook_ve(const char *const *env, const char *name, va_list args);


/* /*
* Trigger an auto-gc * Trigger an auto-gc