kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

builtin/show-ref: fix leaking string buffer 

Fix a leaking string buffer in `git show-ref --exclude-existing`. While
the buffer is technically not leaking because its variable is declared
as static, there is no inherent reason why it should be.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Patrick Steinhardt 2023-10-31 09:16:21 +01:00 committed by Junio C Hamano
parent b14cbae2b5
commit dbabd0b023
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/show-ref.c
View File

@ -106,7 +106,7 @@ static int add_existing(const char *refname,
*/ */
static int cmd_show_ref__exclude_existing(const char *match) static int cmd_show_ref__exclude_existing(const char *match)
{ {
static struct string_list existing_refs = STRING_LIST_INIT_DUP; struct string_list existing_refs = STRING_LIST_INIT_DUP;
char buf[1024]; char buf[1024];
int matchlen = match ? strlen(match) : 0; int matchlen = match ? strlen(match) : 0;


@ -139,6 +139,8 @@ static int cmd_show_ref__exclude_existing(const char *match)
printf("%s\n", buf); printf("%s\n", buf);
} }
} }

string_list_clear(&existing_refs, 0);
return 0; return 0;
} }