Browse Source

Merge branch 'tb/test-lint-sed-options'

The test lint learned to catch non-portable "sed" options.

* tb/test-lint-sed-options:
  test-lint: only use only sed [-n] [-e command] [-f command_file]
maint
Junio C Hamano 6 years ago
parent
commit
d8d62e6135
  1. 2
      t/check-non-portable-shell.pl

2
t/check-non-portable-shell.pl

@ -36,7 +36,7 @@ while (<>) { @@ -36,7 +36,7 @@ while (<>) {
}

/\bcp\s+-a/ and err 'cp -a is not portable';
/\bsed\s+-i/ and err 'sed -i is not portable';
/\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (use type)';

Loading…
Cancel
Save