Browse Source

git-format-patch: do not crash with format.headers without value.

An incorrect config file can say:

	[format]
		headers

and crash the parsing.

Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Junio C Hamano 18 years ago
parent
commit
d7fb91c69d
  1. 6
      builtin-log.c

6
builtin-log.c

@ -202,7 +202,11 @@ static const char *fmt_patch_suffix = ".txt"; @@ -202,7 +202,11 @@ static const char *fmt_patch_suffix = ".txt";
static int git_format_config(const char *var, const char *value)
{
if (!strcmp(var, "format.headers")) {
int len = strlen(value);
int len;

if (!value)
die("format.headers without value");
len = strlen(value);
extra_headers_size += len + 1;
extra_headers = xrealloc(extra_headers, extra_headers_size);
extra_headers[extra_headers_size - len - 1] = 0;

Loading…
Cancel
Save