Browse Source

bisect: clean flags after checking merge bases

Unless there is a good reason to belieave that a particular
invocation of a get_merge_bases*() is the last one that cares about
the object flags the computation of merge bases leaves on the
objects, the "cleanup" parameter should always be true, and I do not
think there is one in this codepath.

Found by code inspection.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Junio C Hamano 10 years ago
parent
commit
d76c9e95b4
  1. 2
      bisect.c

2
bisect.c

@ -776,7 +776,7 @@ static void check_merge_bases(int no_checkout) @@ -776,7 +776,7 @@ static void check_merge_bases(int no_checkout)
int rev_nr;
struct commit **rev = get_bad_and_good_commits(&rev_nr);

result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1, 0);
result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1, 1);

for (; result; result = result->next) {
const unsigned char *mb = result->item->object.sha1;

Loading…
Cancel
Save