sub-process: print the cmd when a capability is unsupported
In handshake_capabilities() we use warning() when a capability
is not supported, so the exit code of the function is 0 and no
further error is shown. This is a problem because the warning
message doesn't tell us which subprocess cmd failed.
On the contrary if we cannot write a packet from this function,
we use error() and then subprocess_start() outputs:
    initialization for subprocess '<cmd>' failed
so we can know which subprocess cmd failed.
Let's improve the warning() message, so that we can know which
subprocess cmd failed.
Helped-by: Lars Schneider <larsxschneider@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
			
			
				maint
			
			
		
							parent
							
								
									fa64a2fdbe
								
							
						
					
					
						commit
						d3ba566342
					
				|  | @ -181,8 +181,8 @@ static int handshake_capabilities(struct child_process *process, | ||||||
| 			if (supported_capabilities) | 			if (supported_capabilities) | ||||||
| 				*supported_capabilities |= capabilities[i].flag; | 				*supported_capabilities |= capabilities[i].flag; | ||||||
| 		} else { | 		} else { | ||||||
| 			warning("external filter requested unsupported filter capability '%s'", | 			warning("subprocess '%s' requested unsupported capability '%s'", | ||||||
| 				p); | 				process->argv[0], p); | ||||||
| 		} | 		} | ||||||
| 	} | 	} | ||||||
|  |  | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue
	
	 Christian Couder
						Christian Couder